Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36119

GhprbBuilds creates wrong GhprbCause: merged vs. mergeable

    XMLWordPrintable

Details

    • Bug
    • Status: Open (View Workflow)
    • Blocker
    • Resolution: Unresolved
    • ghprb-plugin
    • None
    • jenkins 2.9, ghprb plugin 1.32.5

    Description

      org.jenkinsci.plugins.ghprb.GhprbBuilds creates a GhprbCause, but unfortunately assigns the PR.isMergeable property to GhprbCause.merged (see line 58), which in turn causes other "wrong decisions" later (e.g. wrong sha1 env variable - see GhprbTrigger.java line 359).

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          jelmd Jens Elkner created issue -
          rtyler R. Tyler Croy made changes -
          Field Original Value New Value
          Workflow JNJira [ 172772 ] JNJira + In-Review [ 184768 ]
          janinko Honza Brázdil made changes -
          Assignee Honza Brázdil [ janinko ]

          People

            Unassigned Unassigned
            jelmd Jens Elkner
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: