Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4543

Manually uploaded plugins are incorrectly unpacked

      If you upload foo-1.0.hpi, then later upload foo-1.1.hpi, work/plugins contains

      foo-1.0
      foo-1.0.hpi
      foo-1.1
      foo-1.1.hpi

      and Hudson thinks both foo 1.0 and foo 1.1 are installed at the same time,
      causing mayhem.

      Plugins should be unpacked into a directory based on their extension-name or
      short-name or something like this, so that manually uploading a new version of
      the plugin will remove the previous version.

          [JENKINS-4543] Manually uploaded plugins are incorrectly unpacked

          Jesse Glick created issue -

          Jesse Glick added a comment -

          Still broken. Makes it impossible (so far as I can tell) to upload an update of a plugin you built from sources to a running server without waiting for it to be published on the update site.

          Jesse Glick added a comment - Still broken. Makes it impossible (so far as I can tell) to upload an update of a plugin you built from sources to a running server without waiting for it to be published on the update site.
          evernat made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]

          evernat added a comment - - edited

          Changed the priority from Major to Critical because this prevents making hpi files available as downloads when including a version number.
          For example, suggesting the manual install of some beta or RC hpi file will certainly cause problems with multiple versions of the plugin installed.

          evernat added a comment - - edited Changed the priority from Major to Critical because this prevents making hpi files available as downloads when including a version number. For example, suggesting the manual install of some beta or RC hpi file will certainly cause problems with multiple versions of the plugin installed.
          evernat made changes -
          Link New: This issue is related to JENKINS-16306 [ JENKINS-16306 ]

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/PluginManager.java
          http://jenkins-ci.org/commit/jenkins/f1669601e4bd607ffa8a809e109f1ad0c79244b1
          Log:
          [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest.

          Compare: https://github.com/jenkinsci/jenkins/compare/06e459fffebf...f1669601e4bd

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/PluginManager.java http://jenkins-ci.org/commit/jenkins/f1669601e4bd607ffa8a809e109f1ad0c79244b1 Log: [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. Compare: https://github.com/jenkinsci/jenkins/compare/06e459fffebf...f1669601e4bd
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2489
          [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. (Revision f1669601e4bd607ffa8a809e109f1ad0c79244b1)

          Result = SUCCESS
          kohsuke : f1669601e4bd607ffa8a809e109f1ad0c79244b1
          Files :

          • core/src/main/java/hudson/PluginManager.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2489 [FIXED JENKINS-4543] Identify the short name of the plugin from the manifest. (Revision f1669601e4bd607ffa8a809e109f1ad0c79244b1) Result = SUCCESS kohsuke : f1669601e4bd607ffa8a809e109f1ad0c79244b1 Files : core/src/main/java/hudson/PluginManager.java
          Jesse Glick made changes -
          Labels New: lts-candidate

          Jesse Glick added a comment -

          Workaround is to always ensure when using the Upload button that you are selecting a file named pluginShortName.hpi.

          Jesse Glick added a comment - Workaround is to always ensure when using the Upload button that you are selecting a file named pluginShortName.hpi .

            Unassigned Unassigned
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: