Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51852

Since 0.10 the glob matching broken/incompatible

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Between version 0.9 and 0.10, there seems to be a subtle change that causes files not to be found in the workspace. The plain file foo in root of the workspace can not be found using foo pattern, only as **/foo.

      See https://github.com/jenkinsci/acceptance-test-harness/blob/master/src/test/java/plugins/CIFSPublishPluginTest.java for reproducers.

        Attachments

          Activity

          Hide
          slide_o_mix Alex Earl added a comment -

          How do I run the reproduction case?

          Show
          slide_o_mix Alex Earl added a comment - How do I run the reproduction case?
          Hide
          olivergondza Oliver Gondža added a comment -

          See https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/DOCKER.md. It is roughly:

          $ sudo systemctl start docker
          $ ./ath-container.sh
          $ eval $(./vnc.sh)
          $ ./run.sh firefox latest -Dmaven.test.failure.ignore=true -DforkCount=1 -B -Dtest=CIFSPublishPluginTest#publish_resources
          
          Show
          olivergondza Oliver Gondža added a comment - See https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/DOCKER.md . It is roughly: $ sudo systemctl start docker $ ./ath-container.sh $ eval $(./vnc.sh) $ ./run.sh firefox latest -Dmaven.test.failure.ignore=true -DforkCount=1 -B -Dtest=CIFSPublishPluginTest#publish_resources
          Hide
          slide_o_mix Alex Earl added a comment -

          I don't have docker available to me, I only have a Windows PC that I can use right now and I can't install docker on it. I'll try and reproduce another way.

          Show
          slide_o_mix Alex Earl added a comment - I don't have docker available to me, I only have a Windows PC that I can use right now and I can't install docker on it. I'll try and reproduce another way.
          Hide
          slide_o_mix Alex Earl added a comment -

          I am unable to reproduce this on my local instance of Jenkins.

          Show
          slide_o_mix Alex Earl added a comment - I am unable to reproduce this on my local instance of Jenkins.
          Hide
          slide_o_mix Alex Earl added a comment -

          Is there a way to run with a non-released version of the plugin?

          Show
          slide_o_mix Alex Earl added a comment - Is there a way to run with a non-released version of the plugin?
          Show
          olivergondza Oliver Gondža added a comment - Alex Earl , the ATH? sure: https://github.com/jenkinsci/acceptance-test-harness/blob/master/docs/SUT-VERSIONS.md#use-custom-plugin-file
          Hide
          slide_o_mix Alex Earl added a comment -

          When I try and do that I just get errors like this:

          master53668|SEVERE: Failed to install Publish Over CIFS
          master53668|java.io.IOException: Downloaded file /home/ath-user/ath-sources/target/jenkins3939363797066647269home/plugins/publish-over-cifs.jpi.tmp does not match expected SHA-256, expected 'nBOpBcYoY/KfajQw8AQ2XTL3BYPw5xA2onk+w05WFR0=', actual '40fakNRWazpJHrwg3eaW44QFqCMVFhNmV1pJL9SqSYM='
          

          I've tried with running an "mvn install" so that the snapshot is in .m2 and using VERSION_OVERRIDES as well as with LOCAL_JARS.

          Show
          slide_o_mix Alex Earl added a comment - When I try and do that I just get errors like this: master53668|SEVERE: Failed to install Publish Over CIFS master53668|java.io.IOException: Downloaded file /home/ath-user/ath-sources/target/jenkins3939363797066647269home/plugins/publish-over-cifs.jpi.tmp does not match expected SHA-256, expected 'nBOpBcYoY/KfajQw8AQ2XTL3BYPw5xA2onk+w05WFR0=' , actual '40fakNRWazpJHrwg3eaW44QFqCMVFhNmV1pJL9SqSYM=' I've tried with running an "mvn install" so that the snapshot is in .m2 and using VERSION_OVERRIDES as well as with LOCAL_JARS.
          Hide
          olivergondza Oliver Gondža added a comment -

          Hmm, it seems weeklies has broken this aspect of ATH: https://github.com/jenkinsci/jenkins/commit/6dc32977fc6772a2e18452672d69b8b93ea3e832. Try core pre-2.130.

          Show
          olivergondza Oliver Gondža added a comment - Hmm, it seems weeklies has broken this aspect of ATH: https://github.com/jenkinsci/jenkins/commit/6dc32977fc6772a2e18452672d69b8b93ea3e832 . Try core pre-2.130.
          Hide
          slide_o_mix Alex Earl added a comment -

          Ok, that worked. Thanks. The next release version (will be released soon) of the plugin passes the test.

          Show
          slide_o_mix Alex Earl added a comment - Ok, that worked. Thanks. The next release version (will be released soon) of the plugin passes the test.
          Hide
          slide_o_mix Alex Earl added a comment -

          Will be fixed in 0.12

          Show
          slide_o_mix Alex Earl added a comment - Will be fixed in 0.12
          Hide
          olivergondza Oliver Gondža added a comment -

          Alex Earl, Thanks, I have verified https://github.com/jenkinsci/publish-over-cifs-plugin/commit/4e699e09d93d393c5ece95287e657acd904a9bcd fixed the problem. Can you please cut the release (or I can do it if you do not mind), the false positives this causes in acceptance test harness are painful in evaluating Java 11 readiness. Thank you!

          Show
          olivergondza Oliver Gondža added a comment - Alex Earl , Thanks, I have verified https://github.com/jenkinsci/publish-over-cifs-plugin/commit/4e699e09d93d393c5ece95287e657acd904a9bcd fixed the problem. Can you please cut the release (or I can do it if you do not mind), the false positives this causes in acceptance test harness are painful in evaluating Java 11 readiness. Thank you!
          Hide
          slide_o_mix Alex Earl added a comment -

          I'll cut the release today

          Show
          slide_o_mix Alex Earl added a comment - I'll cut the release today
          Hide
          slide_o_mix Alex Earl added a comment -

          Released 0.12

          Show
          slide_o_mix Alex Earl added a comment - Released 0.12
          Hide
          olivergondza Oliver Gondža added a comment -

          Thanks, works as a charm!

          Show
          olivergondza Oliver Gondža added a comment - Thanks, works as a charm!

            People

            Assignee:
            slide_o_mix Alex Earl
            Reporter:
            olivergondza Oliver Gondža
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: