Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-60050

Add title into the ChangeRequestSCMHead interface

    XMLWordPrintable

Details

    Description

      As we know change requests in many git providers are necessary such as GitHub, Gitlab and so on. In my use cases, users want to get the title which they might send build email base on the change request title.

      Attachments

        Issue Links

          Activity

            surenpi Rick created issue -
            surenpi Rick made changes -
            Field Original Value New Value
            Status Open [ 1 ] In Progress [ 3 ]
            surenpi Rick made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            surenpi Rick made changes -
            Remote Link This issue links to "Pull Request (Web Link)" [ 23925 ]
            bitwiseman Liam Newman added a comment -

            I'm sorry, but I disagree with this change.  "ChangeRequestSCMHead" should hold the pertinent SCM information needed to build the the change and I don't see the title as part of that. 

            For example, the title can change without the meaningful SCM information changing. Should the title be included in `equals()` comparisons?  If the title changes, should a new build be triggered?

            I understand it would be convenient to have this information, and I even support the Title of Change requests being added to some shared interface. However, there needs to be some additional discussion of other possible places to add this information and possible effects and changes in behavior.

            I'm sorry. I want to support you in making improvements to this part of the API, but I'm have concerns about this improvement as it stands.

            bitwiseman Liam Newman added a comment - I'm sorry, but I disagree with this change.  "ChangeRequestSCMHead" should hold the pertinent SCM information needed to build the the change and I don't see the title as part of that.  For example, the title can change without the meaningful SCM information changing. Should the title be included in `equals()` comparisons?  If the title changes, should a new build be triggered? I understand it would be convenient to have this information, and I even support the Title of Change requests being added to some shared interface. However, there needs to be some additional discussion of other possible places to add this information and possible effects and changes in behavior. I'm sorry. I want to support you in making improvements to this part of the API, but I'm have concerns about this improvement as it stands.
            surenpi Rick added a comment -

            It's not a perfect solution that putting the title into ChangeRequestSCMHead. Do you have any suggestions about how can we make a connection with it? Maybe add a new interface for the title?

            surenpi Rick added a comment - It's not a perfect solution that putting the title into ChangeRequestSCMHead. Do you have any suggestions about how can we make a connection with it? Maybe add a new interface for the title?

            ObjectMetadataAction (javadoc) has a String getObjectDescription() method that plugins are already using for change request titles. I don't think it's useful to add the same to ChangeRequestSCMHead.

            kon Kalle Niemitalo added a comment - ObjectMetadataAction ( javadoc ) has a String getObjectDescription() method that plugins are already using for change request titles. I don't think it's useful to add the same to ChangeRequestSCMHead.

            People

              surenpi Rick
              surenpi Rick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated: