Details
-
Improvement
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Fixed
-
None
Description
Currently, the SCP Plugin only uses the host name as the "siteName" identifier. This prevents setting two different SCP connections to the same machine (the first instance of a hostname in the connection list is always chosen). This would be useful, for example, if two different projects want to archive artifacts on a shared server, but in different locations - or using a different username. A simple patch is attached (against r33992) that expands the site name to:
USER@hostname:root_path
This allows multiple connections to the same server using either different usernames or different root paths.
Attachments
Activity
jsiirola
created issue -
Code changed in jenkins
User: unknown
Path:
src/main/java/be/certipost/hudson/plugin/SCPRepositoryPublisher.java
src/main/java/be/certipost/hudson/plugin/SCPSite.java
src/main/resources/be/certipost/hudson/plugin/SCPRepositoryPublisher/global.jelly
src/main/webapp/help-displayname.html
http://jenkins-ci.org/commit/scp-plugin/08f5f3b40f5e353decccc2de7566a48c99530d22
Log:
JENKINS-7257 More verbose site name
Add a new field "displayname" that can be used to give a site any name the user wants. If the displayname field is not used, then the displayname will default to username@hostname:rootRepositoryPath
Code changed in jenkins
User: unknown
Path:
src/main/java/be/certipost/hudson/plugin/SCPRepositoryPublisher.java
src/main/java/be/certipost/hudson/plugin/SCPSite.java
src/main/resources/be/certipost/hudson/plugin/SCPRepositoryPublisher/global.jelly
src/main/webapp/help-displayname.html
http://jenkins-ci.org/commit/scp-plugin/08f5f3b40f5e353decccc2de7566a48c99530d22
Log:
JENKINS-7257 More verbose site name
Add a new field "displayname" that can be used to give a site any name the user wants. If the displayname field is not used, then the displayname will default to username@hostname:rootRepositoryPath
Code changed in jenkins
User: Olivier Lamy
Path:
src/main/java/be/certipost/hudson/plugin/SCPRepositoryPublisher.java
src/main/java/be/certipost/hudson/plugin/SCPSite.java
src/main/resources/be/certipost/hudson/plugin/SCPRepositoryPublisher/global.jelly
src/main/webapp/help-displayname.html
http://jenkins-ci.org/commit/scp-plugin/4162acc0c88ec7adf606aa7725e8db460c4c93b9
Log:
Merge pull request #3 from dennisl/master
[FIXED JENKINS-7257] More verbose site name
Compare: https://github.com/jenkinsci/scp-plugin/compare/cdb98bc...4162acc
Code changed in jenkins
User: Olivier Lamy
Path:
src/main/java/be/certipost/hudson/plugin/SCPRepositoryPublisher.java
src/main/java/be/certipost/hudson/plugin/SCPSite.java
src/main/resources/be/certipost/hudson/plugin/SCPRepositoryPublisher/global.jelly
src/main/webapp/help-displayname.html
http://jenkins-ci.org/commit/scp-plugin/4162acc0c88ec7adf606aa7725e8db460c4c93b9
Log:
Merge pull request #3 from dennisl/master
[FIXED JENKINS-7257] More verbose site name
Compare: https://github.com/jenkinsci/scp-plugin/compare/cdb98bc...4162acc
| Field | Original Value | New Value |
|---|---|---|
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
Can you tell us how to apply this patch ?
Thanks in advance !
Regards,
Florent Jouatte
Florent JOUATTE
added a comment - - edited Can you tell us how to apply this patch ?
Thanks in advance !
Regards,
Florent Jouatte | Workflow | JNJira [ 137356 ] | JNJira + In-Review [ 187467 ] |
A different approach would be to simply allow giving every configuration a name, like "Staging environment" or "Test server".
And the best way might be to combine both when choosing a configuration, like:
Staging environment (user@server:path)
Test server (tester@testserver:deploypath)