With version 1.377 and recreating the matrix jobs, the issue is solved. Label and node selections are persistant again.

Without recreating the job, the system only saved the lable part of the configuration (directly after upgrading to 1.377).

(Is it OK to close this issue being the reporter in this case?)

Sorry, too early too happy.

After a while of further configuration work, the issue reappears. Every time I open the configuration all selected nodes and labels are gone again.

do you get any javascript errors reported in your browser?

can you post steps to recreate the issue with a newly created matrix project?

Yes, after some additional tests I've seen the issue occurs when selecting all nodes or all labels only.

1. Create new matrix project
2. Add axis slave
3.a Select all nodes
3.b Select all labels
4. Save
5. Configure again
6. Open axis and all selections are gone

If you select only a subset, the selection will be stored.

In my case I'm only selecting a subset.
1. create new matrix project
2. default axis
3. select subset of labels
4. save
5. configure job
6. all selections are gone
At this point the save results in the exception.

Fails on our Hudson v1.377 system w/15 slaves like so:

Create new matrix project
Configuration Matrix > Add Axis > Slaves > Individual nodes...

Choose all 15 slaves
Reopen saved matrix project
[ FAIL. All slaves are now unchecked ]
Choose 5 slaves
Reopen saved matrix project
[ FAIL. All slaves are now unchecked ]
Choose last 3 slaves
Reopen saved matrix project
[ Everything looks good... ]
Choose last 5 slaves
Reopen saved matrix project
[ Everything looks good... ]
Choose last 7 slaves
Reopen saved matrix project
[ FAIL. All slaves are now unchecked ]
Choose last 5 slaves
Reopen saved matrix project
[ Everything looks good... ]

Thought it may be related to node Decription string length since last 5 slaves have a especially short description. But that didn't seem to matter.

This happens when the total length of the names of the slaves you select exceeds 30 characters. Looks like hudson.matrix.Axis.getValueString() switches from a space delimiter to a newline delimiter at that point.

In LabelAxis/config.jelly there is this bit of html/javascript to help determine what slaves should be checked. I'm guessing the split doesn't work when newlines are used as the delimiter.

<div class="yahooTree labelAxis-tree" style="border: 1px solid gray; height: 10em; overflow:auto;" values="${instance.valueString}" />

...

var values = (e.getAttribute("values") || "").split(" ");
function has(v) {
    return values.include(v) ? 'checked="checked" ' : "";
}

Not being terribly familiar with this code I can't say if this is the best approach, but changing

split(" ")

to...

split(/[ \n]/)

seems to fix the issue. (Not sure if the space in the regex is easy to see - that is splitting on either space or newline)

It's a pity that fixing this didn't make it into 1.378 seeing as the issue seems to have been identified and even possible fixes supplied.

Could we please get this fixed in the next release?

I guess the question to my answer is no. 1.379 is out and this issue is still not fixed (not in the changelog anyway).

It's frustrating that this isn't this getting fixed. It's marked as critical even and rightfully so in that it's entirely annoying that every time I modify a multi-configuration job (i.e. make script changes) I need to re-select all of my nodes/labels. Yes. Very annoying indeed.

If somebody has fixed this locally and can explain how I can fix my local copy I'd be happy to do so until somebody can get this fixed into a release. Thanx.

Confirming that I've hit this issue too putting a new 1.379 install up. My old 1.355 stable install is still working great.

I was going to try the manual fix to config.jelly posted above, but I can't find a LabelAxis dir or a config.jelly with split(" ") in it - any more directions for a patch-fix would be appreciated until this gets fixed for real

I have the same problem with 1.375 also !

The split change does seem to do the trick - I'm not sure the right way to do config round trip testing on this, though, since it's so heavily javascript-based. But local testing looks good - I'll commit this, and it should be in 1.381. Sorry for the delays.

Ah, no, check that, 1.382.

Code changed in hudson
User: : abayer
Path:
branches/rc/core/src/main/resources/hudson/matrix/LabelAxis/config.jelly
http://jenkins-ci.org/commit/35931
Log:
[FIXED JENKINS-7500] Fixed error when saving job configuration with matrix label axis longer than 30 characters

Ok, actually, I was right the first time. =) I put the change into the rc branch, so it should show up in 1.381.

Integrated in hudson_main_trunk #339
Merged revisions 35931,35963,35995,35997,36001 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
r35931 | abayer | 2010-10-14 19:54:34 +0200 (Thu, 14 Oct 2010) | 1 line

[FIXED JENKINS-7500] Fixed error when saving job configuration with matrix label axis longer than 30 characters
........
r35963 | kohsuke | 2010-10-15 10:19:59 +0200 (Fri, 15 Oct 2010) | 1 line

fixed unnecessary packet fragmentation when writing out HTTP responses
........
r35995 | kohsuke | 2010-10-16 18:25:31 +0200 (Sat, 16 Oct 2010) | 1 line

[maven-release-plugin] prepare release hudson-1_381
........
r35997 | kohsuke | 2010-10-16 18:25:44 +0200 (Sat, 16 Oct 2010) | 1 line

[maven-release-plugin] prepare for next development iteration
........
r36001 | kohsuke | 2010-10-16 19:25:57 +0200 (Sat, 16 Oct 2010) | 1 line

updated changelog as a part of the release
........

kohsuke :
Files :

• /trunk/hudson/main
• /trunk/hudson/main/core/pom.xml
• /trunk/hudson/main/war/pom.xml
• /trunk/hudson/main/test/pom.xml
• /trunk/hudson/main/remoting/pom.xml
• /trunk/hudson/main/core/src/main/resources/hudson/matrix/LabelAxis/config.jelly
• /trunk/hudson/main/debian/debian/changelog
• /trunk/hudson/main/maven-plugin/pom.xml
• /trunk/hudson/main/pom.xml
• /trunk/hudson/main/cli/pom.xml
• /trunk/hudson/main/ui-samples-plugin/pom.xml
• /trunk/hudson/main/maven-agent/pom.xml
• /trunk/hudson/main/maven-interceptor/pom.xml