-
New Feature
-
Resolution: Fixed
-
Minor
-
Jenkins 2.57 running using JDK1.8_141 on RH6 Linux, no container
jenkinslint 0.9.0
-
Powered by SuggestiMate
In my understanding, currently I can only exclude a Jenkins Lint rule for a specific job, by "adding a trailing lint:ignore:<check name> comment to the job description."
(This one is tested and worked)
Unfortunately there are some rules, which I would like to ignore completely for now.
Is there a way to do this (besides adding this per-job-exclude to all affected jobs ?)
If no, could this please be added ?
(I tried to add a "-Dlint:ignore:GradleWrapperChecker" to my jenkins startup parameters, because I first misunderstood the docu - this didn't work
Code changed in jenkins
User: Victor Martinez
Path:
README.md
src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/JobLintAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/BFAChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractSlaveCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceSlaveCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Job.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Lint.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Slave.java
src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction/index.jelly
src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration/config.jelly
src/main/resources/org/jenkins/ci/plugins/jenkinslint/JobLintAction/index.jelly
src/main/resources/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction/index.jelly
src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintActionTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfigurationTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/JobLintActionTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintActionTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/AbstractCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchCheckerTestCase.java
http://jenkins-ci.org/commit/jenkinslint-plugin/8be91308e606ed60310171aee1634980d73400a1
Log:
JENKINS-45882 [JENKINS-41528] [JENKINS-42268] Jenkins Lint Global Configuration and new Checkers (#21)
- Initial approach to use GlobalConfiguration
- Added Lint global settings to enable/disable it
- Disabling and Ignoring are now different status.
- Fixed README.md
- Added remaining checkers
- Saving global configuration based on the https://wiki.jenkins.io/display/JENKINS/Manage+global+settings+and+tools+installations
- Some minor bits and pieces to only show defects when they are in the right state
- Fixed Tests to use the enabled flag
- Enabled JobAction managed by GlobalSettings although the system property will be deprecated shortly
- Added Threshold option in the Global Settings
- Added TestCases for the new hardcoded threshold argument/variable
- Added FormValidation Test Case for the Threshold value
- SpeedUp TestCases usng the ClassRule pattern
Code changed in jenkins
User: Victor Martinez
Path:
README.md
src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/JobLintAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/BFAChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchChecker.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractAction.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/AbstractSlaveCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/InterfaceSlaveCheck.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Job.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Lint.java
src/main/java/org/jenkins/ci/plugins/jenkinslint/model/Slave.java
src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintAction/index.jelly
src/main/resources/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfiguration/config.jelly
src/main/resources/org/jenkins/ci/plugins/jenkinslint/JobLintAction/index.jelly
src/main/resources/org/jenkins/ci/plugins/jenkinslint/SlaveLintAction/index.jelly
src/test/java/org/jenkins/ci/plugins/jenkinslint/AbstractTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintActionTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/JenkinsLintGlobalConfigurationTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/JobLintActionTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/SlaveLintActionTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/AbstractCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/ArtifactCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/BFACheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/CleanupWorkspaceCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitRefSubmoduleCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GitShallowCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GradleWrapperCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/GroovySystemExitCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/HardcodedScriptCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JavadocCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobAssignedLabelCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobDescriptionCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobLogRotatorCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/JobNameCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MasterLabelCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MavenJobTypeCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/MultibranchJobTypeCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/NullSCMCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/PollingSCMTriggerCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveDescriptionCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveLabelCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/SlaveVersionCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimeoutCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/TimerTriggerCheckerTestCase.java
src/test/java/org/jenkins/ci/plugins/jenkinslint/check/WindowsSlaveLaunchCheckerTestCase.java
http://jenkins-ci.org/commit/jenkinslint-plugin/c05f72c0219450e1421589bdcb17dcbe612d3d7c
Log:
JENKINS-45882 Jenkins Lint Global Configuration and new Checkers (#21)
- Initial approach to use GlobalConfiguration
- Added Lint global settings to enable/disable it
- Disabling and Ignoring are now different status.
- Fixed README.md
- Added remaining checkers
- Saving global configuration based on the https://wiki.jenkins.io/display/JENKINS/Manage+global+settings+and+tools+installations
- Some minor bits and pieces to only show defects when they are in the right state
- Fixed Tests to use the enabled flag
- Enabled JobAction managed by GlobalSettings although the system property will be deprecated shortly
- Added Threshold option in the Global Settings
- Added TestCases for the new hardcoded threshold argument/variable
- Added FormValidation Test Case for the Threshold value
- SpeedUp TestCases usng the ClassRule pattern
[maven-release-plugin] prepare release jenkinslint-0.10.0
[maven-release-plugin] prepare for next development iteration
[maven-release-plugin] rollback the release of jenkinslint-0.10.0
It is now solved in the upcoming release 0.10.0, which I'm now releasing it
Cheers
Hello,
thanks for the ultra-fast update ! (Need to get a chance for the needed jenkins-restart to update, without upsetting our users)
I guess that one
Regarding "-Dlint:ignore:GradleWrapperChecker" is not intended to work in that way but only as job description level, it's not part of the system properties, the only bit which it's part and will be deprecated shortly is the JobAction View.
Thanks for the feedback about the documentation, feel free to edit it otherwise I'll do it
Needs to go to the plugin itself. What got me assuming this should go to the jenkins start command line, was this
Control Comment: To disable this checker you can add lint:ignore:JobNameChecker to your Jenkins project.
On http://<jenkins>/jenkinslint/?filter=description
What about
"Control Comment*:* To disable this checker you can add lint:ignore:JobNameChecker to your respective Jenkins project description"
?
What confused me had been:
- "project"; I would usually call this "job", but I've seen the arguments on that, when I checked whether to raise a Jenkins ticket on that (https://issues.jenkins-ci.org/browse/JENKINS-7628, https://issues.jenkins-ci.org/browse/JENKINS-1968)
- The missing "description" made me even more think, this is some global thing - and that sounded like some Java property....
Thanks a lot !
Martin
This is something to be rolled out shortly:
There will be a Jenkins Lint Global Settings where those lints can be enabled/disabled globally. Therefore, there will be 4 status:
I'm planing to release it sometime this week.
Regarding "-Dlint:ignore:GradleWrapperChecker" is not intended to work in that way but only as job description level, it's not part of the system properties, the only bit which it's part and will be deprecated shortly is the JobAction View.
Thanks for the feedback about the documentation, feel free to edit it otherwise I'll do it
Cheers