Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10253

Label Alignment does not correctly work for top-level entries that span several lines

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      See screenshot. If you have an entry then the label will be shown centered. This looks good for entries with a single entry field. But not for multi-line entries, see screenshot.

        Attachments

          Activity

          Hide
          bap bap added a comment -

          The effect is much worse with two multiline entries next to each other, there is no way to distinguish which option belongs to which entry.

          The label also jumps around when you expand an advance block within a nested entry, as the entry gets bigger and the label jumps to the new mid point.

          The original pull request https://github.com/jenkinsci/jenkins/pull/175

          And the commit https://github.com/jenkinsci/jenkins/commit/9ddf000f2b42c71e0c3bfbda09da06db444ccbe6

          Show
          bap bap added a comment - The effect is much worse with two multiline entries next to each other, there is no way to distinguish which option belongs to which entry. The label also jumps around when you expand an advance block within a nested entry, as the entry gets bigger and the label jumps to the new mid point. The original pull request https://github.com/jenkinsci/jenkins/pull/175 And the commit https://github.com/jenkinsci/jenkins/commit/9ddf000f2b42c71e0c3bfbda09da06db444ccbe6
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: bap2000
          Path:
          changelog.html
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/5936e970fbf7e31c46272c74f358f058a36b9b0a
          Log:
          Revert "Set setting-name class to have vertical-align: middle property."

          This reverts commit 9ddf000f2b42c71e0c3bfbda09da06db444ccbe6.
          [FIXED JENKINS-10253] Label Alignment does not correctly work for top-level entries that span several lines

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: bap2000 Path: changelog.html war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/5936e970fbf7e31c46272c74f358f058a36b9b0a Log: Revert "Set setting-name class to have vertical-align: middle property." This reverts commit 9ddf000f2b42c71e0c3bfbda09da06db444ccbe6. [FIXED JENKINS-10253] Label Alignment does not correctly work for top-level entries that span several lines
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: bap2000
          Path:
          changelog.html
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/5936e970fbf7e31c46272c74f358f058a36b9b0a
          Log:
          Revert "Set setting-name class to have vertical-align: middle property."

          This reverts commit 9ddf000f2b42c71e0c3bfbda09da06db444ccbe6.
          [FIXED JENKINS-10253] Label Alignment does not correctly work for top-level entries that span several lines

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: bap2000 Path: changelog.html war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/5936e970fbf7e31c46272c74f358f058a36b9b0a Log: Revert "Set setting-name class to have vertical-align: middle property." This reverts commit 9ddf000f2b42c71e0c3bfbda09da06db444ccbe6. [FIXED JENKINS-10253] Label Alignment does not correctly work for top-level entries that span several lines
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: bap2000
          Path:
          changelog.html
          war/src/main/webapp/css/style.css
          http://jenkins-ci.org/commit/jenkins/5936e970fbf7e31c46272c74f358f058a36b9b0a
          Log:
          Revert "Set setting-name class to have vertical-align: middle property."

          This reverts commit 9ddf000f2b42c71e0c3bfbda09da06db444ccbe6.
          [FIXED JENKINS-10253] Label Alignment does not correctly work for top-level entries that span several lines

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: bap2000 Path: changelog.html war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/5936e970fbf7e31c46272c74f358f058a36b9b0a Log: Revert "Set setting-name class to have vertical-align: middle property." This reverts commit 9ddf000f2b42c71e0c3bfbda09da06db444ccbe6. [FIXED JENKINS-10253] Label Alignment does not correctly work for top-level entries that span several lines

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            drulli Ulli Hafner
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: