Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10255

Mercurial Changelog should compare with previous build

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • mercurial-plugin
    • None

      Mercurial Changelog should compare with revision of the previous build instead of relying on local changes.
      When using multiple slaves, current implementation is taking in account changes which were already tested by a previous build on a different slave.
      Also, when a workspace is wiped out (or a new slave installed), changelog is empty since a full clone was needed.
      That wanted behavior is already implemented by other SCM plugins.

          [JENKINS-10255] Mercurial Changelog should compare with previous build

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David M. Carr
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          http://jenkins-ci.org/commit/mercurial-plugin/ef5b34289131b737a4329fc6544015e79be01c96
          Log:
          Minor touchups for JENKINS-11363 and JENKINS-10255.
          Extract an anonymous class as inner class CheckForReusableWorkspace.
          Provide more informative error/warning logging.
          Eliminate redundant update when cleaning enabled.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: David M. Carr Path: src/main/java/hudson/plugins/mercurial/MercurialSCM.java http://jenkins-ci.org/commit/mercurial-plugin/ef5b34289131b737a4329fc6544015e79be01c96 Log: Minor touchups for JENKINS-11363 and JENKINS-10255 . Extract an anonymous class as inner class CheckForReusableWorkspace. Provide more informative error/warning logging. Eliminate redundant update when cleaning enabled.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David M. Carr
          Path:
          src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          src/test/java/hudson/plugins/mercurial/ForestTest.java
          src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java
          src/test/java/hudson/plugins/mercurial/MercurialTestCase.java
          http://jenkins-ci.org/commit/mercurial-plugin/d50764a8c3ca8ca121d53c8a41630de55e12696a
          Log:
          JENKINS-10255 Add more tests for polling, and fix a bug with the new polling when multiple changesets are involved.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: David M. Carr Path: src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/test/java/hudson/plugins/mercurial/ForestTest.java src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java src/test/java/hudson/plugins/mercurial/MercurialTestCase.java http://jenkins-ci.org/commit/mercurial-plugin/d50764a8c3ca8ca121d53c8a41630de55e12696a Log: JENKINS-10255 Add more tests for polling, and fix a bug with the new polling when multiple changesets are involved.

          dogfood added a comment -

          Integrated in plugins_mercurial #59
          [FIXED JENKINS-10255] : changelog is now based on the changes since the previous build, rather than the changes since the latest build on this slave, which can be quite different.
          JENKINS-10255 Touch up the tests I added for the changelog issues (which were applied as patches by willemv).
          Minor touchups for JENKINS-11363 and JENKINS-10255.
          JENKINS-10255 Add more tests for polling, and fix a bug with the new polling when multiple changesets are involved.

          willem.verstraeten :
          Files :

          • src/main/java/hudson/plugins/mercurial/MercurialChangeLogParser.java
          • src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          • src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java

          david :
          Files :

          • src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java

          david :
          Files :

          • src/main/java/hudson/plugins/mercurial/MercurialSCM.java

          david :
          Files :

          • src/test/java/hudson/plugins/mercurial/MercurialTestCase.java
          • src/test/java/hudson/plugins/mercurial/ForestTest.java
          • src/main/java/hudson/plugins/mercurial/MercurialSCM.java
          • src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java

          dogfood added a comment - Integrated in plugins_mercurial #59 [FIXED JENKINS-10255] : changelog is now based on the changes since the previous build, rather than the changes since the latest build on this slave, which can be quite different. JENKINS-10255 Touch up the tests I added for the changelog issues (which were applied as patches by willemv). Minor touchups for JENKINS-11363 and JENKINS-10255 . JENKINS-10255 Add more tests for polling, and fix a bug with the new polling when multiple changesets are involved. willem.verstraeten : Files : src/main/java/hudson/plugins/mercurial/MercurialChangeLogParser.java src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java david : Files : src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java david : Files : src/main/java/hudson/plugins/mercurial/MercurialSCM.java david : Files : src/test/java/hudson/plugins/mercurial/MercurialTestCase.java src/test/java/hudson/plugins/mercurial/ForestTest.java src/main/java/hudson/plugins/mercurial/MercurialSCM.java src/test/java/hudson/plugins/mercurial/MercurialSCMTest.java

          David Santiago Turiño added a comment -

          This is fixed but not assigned to any revision (current or whatever).

          David Santiago Turiño added a comment - This is fixed but not assigned to any revision (current or whatever).

          David Santiago Turiño added a comment -

          Hum... this was fixed one month ago and has not been included in any of the last 5 releases. Does anybody know when will it be released?

          David Santiago Turiño added a comment - Hum... this was fixed one month ago and has not been included in any of the last 5 releases. Does anybody know when will it be released?

          Jesse Glick added a comment -

          As far as I know there have been no recent releases of the plugin. I would happily release it but I would only be testing on Hudson and the current Maven metadata is I think set up to advertise only on the Jenkins update center. If there is someone out there who knows the magic parent POM (or whatever) needed to publish simultaneously to both update centers, that would be great.

          Jesse Glick added a comment - As far as I know there have been no recent releases of the plugin. I would happily release it but I would only be testing on Hudson and the current Maven metadata is I think set up to advertise only on the Jenkins update center. If there is someone out there who knows the magic parent POM (or whatever) needed to publish simultaneously to both update centers, that would be great.

          David Santiago Turiño added a comment -

          Jesse, you mean that you tested it only with hudson and not with jenkins?

          David Santiago Turiño added a comment - Jesse, you mean that you tested it only with hudson and not with jenkins?

          Jesse Glick added a comment -

          I have not tested this change at all.

          Jesse Glick added a comment - I have not tested this change at all.

          davidmc24 added a comment -

          I had tested it with Jenkins. It appears that Kohsuke released version 1.38 yesterday, which should include this fix.

          davidmc24 added a comment - I had tested it with Jenkins. It appears that Kohsuke released version 1.38 yesterday, which should include this fix.

          David Santiago Turiño added a comment -

          Cool, thanks for the feedback davidmc24

          David Santiago Turiño added a comment - Cool, thanks for the feedback davidmc24

            davidmc24 davidmc24
            jcarsique Julien Carsique
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: