Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10367

When building the dependency graph, maven modules which are not buildable should be ignored

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • maven-plugin
    • None

      Currently only modules which are disabled themselves - i.e. are no longer part of the moduleset - are excluded.
      We should also exclude modules which are not buildable - i.e. whose MavenModuleSets are disabled.

      See MavenModule#buildDependencyGraph()
      for (MavenModule m : Hudson.getInstance().getAllItems(MavenModule.class)) {
      if(m.isDisabled()) continue;

      should be replaced with
      for (MavenModule m : Hudson.getInstance().getAllItems(MavenModule.class)) {
      if(!m.isBuildable()) continue;

          [JENKINS-10367] When building the dependency graph, maven modules which are not buildable should be ignored

          kutzi added a comment -

          kutzi added a comment - Added a pull request https://github.com/jenkinsci/jenkins/pull/200

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          maven-plugin/src/main/java/hudson/maven/MavenModule.java
          http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c
          Log:
          [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a
          Log:
          Changelog for JENKINS-10366 JENKINS-10367

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a Log: Changelog for JENKINS-10366 JENKINS-10367

          dogfood added a comment -

          Integrated in jenkins_main_trunk #982
          [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
          Changelog for JENKINS-10366 JENKINS-10367

          Christoph Kutzinski : 4d8d95b5172387a0f73c61e68eb9aced65da7d7c
          Files :

          • maven-plugin/src/main/java/hudson/maven/MavenModule.java

          Christoph Kutzinski : 315d2b611b1278014493c89fde99c9f1603e334a
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #982 [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph Changelog for JENKINS-10366 JENKINS-10367 Christoph Kutzinski : 4d8d95b5172387a0f73c61e68eb9aced65da7d7c Files : maven-plugin/src/main/java/hudson/maven/MavenModule.java Christoph Kutzinski : 315d2b611b1278014493c89fde99c9f1603e334a Files : changelog.html

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          maven-plugin/src/main/java/hudson/maven/MavenModule.java
          http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c
          Log:
          [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a
          Log:
          Changelog for JENKINS-10366 JENKINS-10367

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a Log: Changelog for JENKINS-10366 JENKINS-10367

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          maven-plugin/src/main/java/hudson/maven/MavenModule.java
          http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c
          Log:
          [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/jenkins/4d8d95b5172387a0f73c61e68eb9aced65da7d7c Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a
          Log:
          Changelog for JENKINS-10366 JENKINS-10367

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/315d2b611b1278014493c89fde99c9f1603e334a Log: Changelog for JENKINS-10366 JENKINS-10367

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/maven/MavenModule.java
          http://jenkins-ci.org/commit/maven-plugin/592a67d8ee1d0e1d6456458837d8723669a1ffc3
          Log:
          [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph
          Originally-Committed-As: 4d8d95b5172387a0f73c61e68eb9aced65da7d7c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/maven/MavenModule.java http://jenkins-ci.org/commit/maven-plugin/592a67d8ee1d0e1d6456458837d8723669a1ffc3 Log: [FIXED JENKINS-10367] Maven modules which are not buildable should be excluded from the dependency graph Originally-Committed-As: 4d8d95b5172387a0f73c61e68eb9aced65da7d7c

            kutzi kutzi
            kutzi kutzi
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: