Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10449

Excluded regions do not exclude commits from changelog

    XMLWordPrintable

Details

    Description

      When using Excluded Regions to exclude certain parts of a repository from triggering a build (because it does not affect the build), the commits performed to those excluded regions are still listed in the changelog. If this is a feature and not a bug, it'd be great to at least have an option to exclude them from the changelog.

      Attachments

        Activity

          Descending order - Click to sort in ascending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/scm/DefaultSVNLogFilter.java
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/NullSVNLogFilter.java
          src/main/java/hudson/scm/SVNLogFilter.java
          src/main/java/hudson/scm/SubversionChangeLogBuilder.java
          src/main/java/hudson/scm/SubversionSCM.java
          src/main/resources/hudson/scm/SubversionSCM/config.jelly
          src/main/resources/hudson/scm/SubversionSCM/help-filterChangelog.html
          src/test/java/hudson/scm/DefaultSVNLogFilterTest.java
          src/test/java/hudson/scm/SubversionSCMTest.java
          src/test/java/hudson/scm/SubversionSCMUnitTest.java
          src/test/resources/hudson/scm/JENKINS-10449.zip
          http://jenkins-ci.org/commit/subversion-plugin/72be6320a61f79ec329e0f42b496dbac8fff1644
          Log:
          Merge pull request #27 from batkinson/JENKINS-10449

          Filter changelog based on the same inclusion/exclusion filters used to detect changes. [FIXED JENKINS-10449]

          Compare: https://github.com/jenkinsci/subversion-plugin/compare/ed8a1f80131f...72be6320a61f

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/DefaultSVNLogFilter.java src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/NullSVNLogFilter.java src/main/java/hudson/scm/SVNLogFilter.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionSCM.java src/main/resources/hudson/scm/SubversionSCM/config.jelly src/main/resources/hudson/scm/SubversionSCM/help-filterChangelog.html src/test/java/hudson/scm/DefaultSVNLogFilterTest.java src/test/java/hudson/scm/SubversionSCMTest.java src/test/java/hudson/scm/SubversionSCMUnitTest.java src/test/resources/hudson/scm/ JENKINS-10449 .zip http://jenkins-ci.org/commit/subversion-plugin/72be6320a61f79ec329e0f42b496dbac8fff1644 Log: Merge pull request #27 from batkinson/ JENKINS-10449 Filter changelog based on the same inclusion/exclusion filters used to detect changes. [FIXED JENKINS-10449] Compare: https://github.com/jenkinsci/subversion-plugin/compare/ed8a1f80131f...72be6320a61f
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Brent Atkinson
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SVNLogFilter.java
          src/main/java/hudson/scm/SubversionChangeLogBuilder.java
          src/main/java/hudson/scm/SubversionSCM.java
          http://jenkins-ci.org/commit/subversion-plugin/f71918fc997a38fab6b9133942b8ee68e70c999c
          Log:
          JENKINS-10449 Factored out svnlog filter to use with detection and changelogs

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Brent Atkinson Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SVNLogFilter.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionSCM.java http://jenkins-ci.org/commit/subversion-plugin/f71918fc997a38fab6b9133942b8ee68e70c999c Log: JENKINS-10449 Factored out svnlog filter to use with detection and changelogs
          batkinson Brent Atkinson added a comment -

          Refactored the filtering test so it tests both the old and new behavior, should be good to go.

          batkinson Brent Atkinson added a comment - Refactored the filtering test so it tests both the old and new behavior, should be good to go.
          batkinson Brent Atkinson added a comment -

          The updated pull request now implements optional filtering of the changelog. All existing behavior is left intact, and the default for new configurations is not to filter the changelog.

          batkinson Brent Atkinson added a comment - The updated pull request now implements optional filtering of the changelog. All existing behavior is left intact, and the default for new configurations is not to filter the changelog.
          kutzi kutzi added a comment -

          No, this would only apply for the subversion plugin. The Git plugin is a completely different codebase.

          kutzi kutzi added a comment - No, this would only apply for the subversion plugin. The Git plugin is a completely different codebase.
          View 11 older comments

          People

            Unassigned Unassigned
            jorgenpt Jørgen Tjernø
            Votes:
            6 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: