Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11669

Parameterized trigger from a multi-configuration project triggers downstream jobs twice

    XMLWordPrintable

Details

    Description

      An upstream multi-configuration project with a parameterized trigger schedules the downstream project twice.

      Log output from a multi-configuration job with two parameterized triggers (unit_test and test_suite,test_suite-valgrind):

      Triggering a new build of test_suite #21
      Triggering a new build of test_suite-valgrind #14
      Triggering a new build of unit_test #26
      Triggering a new build of test_suite #22
      Triggering a new build of test_suite-valgrind #15
      Triggering a new build of unit_test #27

      Attachments

        Activity

          Descending order - Click to sort in ascending order
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: cjo9900
          Path:
          src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/86e296911721d42ccf0d03749002e753bb8ed514
          Log:
          Merge branch 'JENKINS-11669' of git://github.com/cjo9900/parameterized-trigger-plugin into 2.17-RC

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: cjo9900 Path: src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java http://jenkins-ci.org/commit/parameterized-trigger-plugin/86e296911721d42ccf0d03749002e753bb8ed514 Log: Merge branch ' JENKINS-11669 ' of git://github.com/cjo9900/parameterized-trigger-plugin into 2.17-RC
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: cjo9900
          Path:
          src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/0ca4cbd2b9456b853be57bf8410bb24ee387effc
          Log:
          [FIXED JENKINS-11669] Removed MatrixAggregator

          Removed MatrixAggregator as not required after Jenkins 1.387 as
          BuildTrigger is called from AbstractBuild.cleanup() in all cases
          and we require 1.424 at the minimum.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: cjo9900 Path: src/main/java/hudson/plugins/parameterizedtrigger/BuildTrigger.java http://jenkins-ci.org/commit/parameterized-trigger-plugin/0ca4cbd2b9456b853be57bf8410bb24ee387effc Log: [FIXED JENKINS-11669] Removed MatrixAggregator Removed MatrixAggregator as not required after Jenkins 1.387 as BuildTrigger is called from AbstractBuild.cleanup() in all cases and we require 1.424 at the minimum.
          cjo9900 cjo9900 added a comment -

          Pull request
          https://github.com/jenkinsci/parameterized-trigger-plugin/pull/33

          cjo9900 cjo9900 added a comment - Pull request https://github.com/jenkinsci/parameterized-trigger-plugin/pull/33
          cjo9900 cjo9900 added a comment -

          Tracked this down to the fact that hudson.Tasks.BuildTrigger.execute() is called from AbstractBuild.cleanup() and from the Parameterizedtrigger.BuildTrigger.MatrixAggregator.endbuild().

          This seemed to be caused by commit on jenkins back in 2010-11-05

          https://github.com/jenkinsci/jenkins/commit/1d6ef2063eebaba39973c6dd56343e1912611db7

          and the change to the parameterized trigger added before it in 2010-07-01

          https://github.com/jenkinsci/parameterized-trigger-plugin/commit/3c302ccf324de5eadf5b244d2ef1ee1a78caf0d7

          So to fix this issue the parameterized trigger plugin should not create the MatrixAggregator, if the version of jenkins is newer than 1.387

          cjo9900 cjo9900 added a comment - Tracked this down to the fact that hudson.Tasks.BuildTrigger.execute() is called from AbstractBuild.cleanup() and from the Parameterizedtrigger.BuildTrigger.MatrixAggregator.endbuild(). This seemed to be caused by commit on jenkins back in 2010-11-05 https://github.com/jenkinsci/jenkins/commit/1d6ef2063eebaba39973c6dd56343e1912611db7 and the change to the parameterized trigger added before it in 2010-07-01 https://github.com/jenkinsci/parameterized-trigger-plugin/commit/3c302ccf324de5eadf5b244d2ef1ee1a78caf0d7 So to fix this issue the parameterized trigger plugin should not create the MatrixAggregator, if the version of jenkins is newer than 1.387
          samt Sam Talebbeik added a comment -

          We are also occasionally seeing this issue. We have a multi-configuration build job and it triggers a post build job. We are using version 2.13 of the parametrized trigger plugin, with Jenkins version Jenkins ver. 1.454 running on Ubuntu server.

          samt Sam Talebbeik added a comment - We are also occasionally seeing this issue. We have a multi-configuration build job and it triggers a post build job. We are using version 2.13 of the parametrized trigger plugin, with Jenkins version Jenkins ver. 1.454 running on Ubuntu server.
          View 4 older comments

          People

            cjo9900 cjo9900
            darnaut Davi Arnaut
            Votes:
            5 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: