Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12070

TAP Plugin: trend graph contains broken link to tap results

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The trend graph that's added to the build dashboard contains a link from the area graph (of count of successful tests vs. build) to the interpreted TAP results. This link is hard-coded to the relative URL "/tap/", when the results are actually published to "/tapResults/". Instead, it should use the same variable that defines the publication location of the TAP results, AbstractTapProjectAction.URL_NAME, not only to fix the defect, but to comply with the DRY principle.

        Attachments

          Activity

          Hide
          kinow Bruno P. Kinoshita added a comment -

          Nice catch David! I have some spare time until Christmas, so I fix it in the following days. Thanks!

          Show
          kinow Bruno P. Kinoshita added a comment - Nice catch David! I have some spare time until Christmas, so I fix it in the following days. Thanks!
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David McGuire
          Path:
          src/main/java/org/tap4j/plugin/util/GraphHelper.java
          http://jenkins-ci.org/commit/tap-plugin/b4d5702e7138aa76ae630945592934bb6deadb49
          Log:
          Fixed JENKINS-12070

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: David McGuire Path: src/main/java/org/tap4j/plugin/util/GraphHelper.java http://jenkins-ci.org/commit/tap-plugin/b4d5702e7138aa76ae630945592934bb6deadb49 Log: Fixed JENKINS-12070
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/java/org/tap4j/plugin/util/GraphHelper.java
          http://jenkins-ci.org/commit/tap-plugin/9548c35ceb7cbb91e13a103350a2578d48fde816
          Log:
          Merge pull request #1 from davidmcguire/master

          JENKINS-12070 TAP Plugin: trend graph contains broken link to tap results

          Compare: https://github.com/jenkinsci/tap-plugin/compare/de2bb9e...9548c35

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/tap4j/plugin/util/GraphHelper.java http://jenkins-ci.org/commit/tap-plugin/9548c35ceb7cbb91e13a103350a2578d48fde816 Log: Merge pull request #1 from davidmcguire/master JENKINS-12070 TAP Plugin: trend graph contains broken link to tap results Compare: https://github.com/jenkinsci/tap-plugin/compare/de2bb9e...9548c35
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Fixed in 1.2.5. It will be available in the update center in few hours. Thanks!

          Show
          kinow Bruno P. Kinoshita added a comment - Fixed in 1.2.5. It will be available in the update center in few hours. Thanks!

            People

            Assignee:
            kinow Bruno P. Kinoshita
            Reporter:
            dmcguire David McGuire
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: