Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13448

Guice injector failure can cause failure of whole Jenkins

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Critical
    • Resolution: Fixed
    • core
    • None

    Description

      When Guice fails to create injector (e.g. because some extension point is optional and therefore missing), it can break other plugins and eventually crash whole Jenkins, see e.g. JENKINS-12970, JENKINS-13385, JENKINS-13381.

      Attachments

        Activity

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          core/src/main/java/hudson/ExtensionFinder.java
          http://jenkins-ci.org/commit/jenkins/6788f82a2c9f8e3580440913c2d39f1d1dc3ad70
          Log:
          [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: core/src/main/java/hudson/ExtensionFinder.java http://jenkins-ci.org/commit/jenkins/6788f82a2c9f8e3580440913c2d39f1d1dc3ad70 Log: [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins.
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1658
          [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins. (Revision 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70)

          Result = UNSTABLE
          Vojtech Juranek : 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70
          Files :

          • core/src/main/java/hudson/ExtensionFinder.java
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1658 [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins. (Revision 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70) Result = UNSTABLE Vojtech Juranek : 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70 Files : core/src/main/java/hudson/ExtensionFinder.java
          dogfood dogfood added a comment -

          Integrated in jenkins_ui-changes_branch #21
          [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins. (Revision 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70)

          Result = SUCCESS
          Vojtech Juranek : 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70
          Files :

          • core/src/main/java/hudson/ExtensionFinder.java
          dogfood dogfood added a comment - Integrated in jenkins_ui-changes_branch #21 [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins. (Revision 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70) Result = SUCCESS Vojtech Juranek : 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70 Files : core/src/main/java/hudson/ExtensionFinder.java

          Code changed in jenkins
          User: Vojtech Juranek
          Path:
          core/src/main/java/hudson/ExtensionFinder.java
          http://jenkins-ci.org/commit/jenkins/91d88d0508c09a8fbc42f8187347c90c8b79e47e
          Log:
          [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins.
          (cherry picked from commit 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70)

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtech Juranek Path: core/src/main/java/hudson/ExtensionFinder.java http://jenkins-ci.org/commit/jenkins/91d88d0508c09a8fbc42f8187347c90c8b79e47e Log: [FIXED JENKINS-13448] Added additional checks if Guice will be able to create injector to exclude missing extension poins. (cherry picked from commit 6788f82a2c9f8e3580440913c2d39f1d1dc3ad70)

          People

            Unassigned Unassigned
            vjuranek vjuranek
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: