Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13496

Add more mimetypes recognized by default

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Nowadays Jenkins declares only few mimetypes : https://github.com/jenkinsci/jenkins/blob/master/war/src/main/webapp/WEB-INF/web.xml
      The issue is that the real list of mimetypes recognized depends a lot of the container used to host jenkins. There is a large list of choices managed by Tomcat but it is really poor for winstone and thus when we are browsing a workspace we may have various issues on files like PDF and co.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            war/pom.xml
            http://jenkins-ci.org/commit/jenkins/e6a8d5e6449161a954dfe9998763906923555650
            Log:
            [FIXED JENKINS-13496 JENKINS-12854] Integrated the newer version of Winstone.

            Compare: https://github.com/jenkinsci/jenkins/compare/71ad43a...e6a8d5e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html war/pom.xml http://jenkins-ci.org/commit/jenkins/e6a8d5e6449161a954dfe9998763906923555650 Log: [FIXED JENKINS-13496 JENKINS-12854] Integrated the newer version of Winstone. Compare: https://github.com/jenkinsci/jenkins/compare/71ad43a...e6a8d5e
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            src/java/winstone/mime.properties
            http://jenkins-ci.org/commit/winstone/351d12e40cc38edcfc87a89db651fb140e53cf1b
            Log:
            [FIXED JENKINS-13496]

            Added more MIME type mappings from
            https://github.com/jenkinsci/jenkins/pull/447

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: src/java/winstone/mime.properties http://jenkins-ci.org/commit/winstone/351d12e40cc38edcfc87a89db651fb140e53cf1b Log: [FIXED JENKINS-13496] Added more MIME type mappings from https://github.com/jenkinsci/jenkins/pull/447
            Hide
            ohtake_tomohiro OHTAKE Tomohiro added a comment -

            The issue regarding PDF on Chrome might be related to JENKINS-13125.

            Show
            ohtake_tomohiro OHTAKE Tomohiro added a comment - The issue regarding PDF on Chrome might be related to JENKINS-13125 .
            Hide
            aheritier Arnaud Héritier added a comment -

            This the result after applying pull request https://github.com/jenkinsci/jenkins/pull/447

            Show
            aheritier Arnaud Héritier added a comment - This the result after applying pull request https://github.com/jenkinsci/jenkins/pull/447
            Hide
            aheritier Arnaud Héritier added a comment -

            This fix isn't enough. We have also some different cases (for pdf files) depending of the browser.
            More tests to do.
            Quick overview :

            • FF :
              • Click on PDF filename link = download
              • Click on PDF *view link* = broken
            • Safari :
              • Click on PDF filename link = preview in browser
              • Click on PDF *view link* = download (mimetype = application/octet-stream)
            • Chrome dev
              • Click on PDF filename link = marked as loading but never ends
              • Click on PDF *view link* = marked as loading but never ends
            Show
            aheritier Arnaud Héritier added a comment - This fix isn't enough. We have also some different cases (for pdf files) depending of the browser. More tests to do. Quick overview : FF : Click on PDF filename link = download Click on PDF * view link * = broken Safari : Click on PDF filename link = preview in browser Click on PDF * view link * = download (mimetype = application/octet-stream) Chrome dev Click on PDF filename link = marked as loading but never ends Click on PDF * view link * = marked as loading but never ends
            Hide
            aheritier Arnaud Héritier added a comment -

            This fix is a larger fix of issues around JENKINS-3808
            The copy/paste is crappy but I don't see a better choice and would to avoid to see many issues reported depending of the container

            Show
            aheritier Arnaud Héritier added a comment - This fix is a larger fix of issues around JENKINS-3808 The copy/paste is crappy but I don't see a better choice and would to avoid to see many issues reported depending of the container

              People

              Assignee:
              aheritier Arnaud Héritier
              Reporter:
              aheritier Arnaud Héritier
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: