Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14585

Test Failure Claim Link not present for Maven test results

      First, thanks for this great plugin.

      This seems to work great for Freestyle projects.

      We're seeing an issue, however, when using it with Maven projects.

      In particular, although it is possible to claim build failures, it does not seem to be possible to claim test failures in the maven results – the 'claim' link is not present, nor is the text saying this test has not yet been claimed, even though we have enabled the 'allow claiming of failed tests' in our job configuration.

          [JENKINS-14585] Test Failure Claim Link not present for Maven test results

          My bad, I closed this as part cleaning up some old issues.
          (Since you commented on this more than 2 weeks ago implying that it was a configuration error and without a reply from Steve Roth.)

          Christian Bremer added a comment - My bad, I closed this as part cleaning up some old issues. (Since you commented on this more than 2 weeks ago implying that it was a configuration error and without a reply from Steve Roth.)

          kutzi added a comment - - edited

          Probably that this doesn't work because the plugin only implements 'TestDataPublisher', but not 'MavenTestDataPublisher'
          Though, I wonder why it shows up as an option in the Maven job config, at all.

          No sorry, that's completely wrong MavenTestDataPublisher is a Recorder for Maven jobs which applies the TestDataPublishers to Maven jobs.
          So this 'should' work

          kutzi added a comment - - edited Probably that this doesn't work because the plugin only implements 'TestDataPublisher', but not 'MavenTestDataPublisher' Though, I wonder why it shows up as an option in the Maven job config, at all. No sorry, that's completely wrong MavenTestDataPublisher is a Recorder for Maven jobs which applies the TestDataPublishers to Maven jobs. So this 'should' work

          kutzi added a comment -

          I've just debugged this and it seems like this is a bug in the MavenTestDataPublisher in Jenkins core.
          MavenTestDataPublisher is only called for the aggregated MavenModuleSetBuild (and not for the individual MavenBuilds) - which may be okay or not, that's debatable.
          However, the bug is that it checks if there is a SurefireReport action attached to the MavenModuleSetBuild, but there is never is one:
          MavenModuleSetBuilds only have SurefireAggregatedReports!

          kutzi added a comment - I've just debugged this and it seems like this is a bug in the MavenTestDataPublisher in Jenkins core. MavenTestDataPublisher is only called for the aggregated MavenModuleSetBuild (and not for the individual MavenBuilds) - which may be okay or not, that's debatable. However, the bug is that it checks if there is a SurefireReport action attached to the MavenModuleSetBuild, but there is never is one: MavenModuleSetBuilds only have SurefireAggregatedReports!

          kutzi added a comment -

          I've opened a pull request with a supposed fix https://github.com/jenkinsci/jenkins/pull/810

          kutzi added a comment - I've opened a pull request with a supposed fix https://github.com/jenkinsci/jenkins/pull/810

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          maven-plugin/src/main/java/hudson/maven/MavenTestDataPublisher.java
          http://jenkins-ci.org/commit/jenkins/8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419
          Log:
          JENKINS-14585 MavenTestDataPublisher didn't do anything

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenTestDataPublisher.java http://jenkins-ci.org/commit/jenkins/8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419 Log: JENKINS-14585 MavenTestDataPublisher didn't do anything

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          maven-plugin/src/main/java/hudson/maven/MavenTestDataPublisher.java
          http://jenkins-ci.org/commit/jenkins/84ee0de3238e811a4f2df94ed7e2cda7518f246f
          Log:
          Merge pull request #810 from kutzi/claim-plugin-fix

          JENKINS-14585 core side fix for: claim-plugin cannot claim broken tests in maven jobs

          Compare: https://github.com/jenkinsci/jenkins/compare/3fdba721fe1f...84ee0de3238e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: maven-plugin/src/main/java/hudson/maven/MavenTestDataPublisher.java http://jenkins-ci.org/commit/jenkins/84ee0de3238e811a4f2df94ed7e2cda7518f246f Log: Merge pull request #810 from kutzi/claim-plugin-fix JENKINS-14585 core side fix for: claim-plugin cannot claim broken tests in maven jobs Compare: https://github.com/jenkinsci/jenkins/compare/3fdba721fe1f...84ee0de3238e

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/20bd2fcad1040a72e1b331b622c063bf2e36256b
          Log:
          [FIXED JENKINS-14585] Noting

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: changelog.html http://jenkins-ci.org/commit/jenkins/20bd2fcad1040a72e1b331b622c063bf2e36256b Log: [FIXED JENKINS-14585] Noting

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2691
          JENKINS-14585 MavenTestDataPublisher didn't do anything (Revision 8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419)
          [FIXED JENKINS-14585] Noting (Revision 20bd2fcad1040a72e1b331b622c063bf2e36256b)

          Result = UNSTABLE
          Christoph Kutzinski : 8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419
          Files :

          • maven-plugin/src/main/java/hudson/maven/MavenTestDataPublisher.java

          Christoph Kutzinski : 20bd2fcad1040a72e1b331b622c063bf2e36256b
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2691 JENKINS-14585 MavenTestDataPublisher didn't do anything (Revision 8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419) [FIXED JENKINS-14585] Noting (Revision 20bd2fcad1040a72e1b331b622c063bf2e36256b) Result = UNSTABLE Christoph Kutzinski : 8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419 Files : maven-plugin/src/main/java/hudson/maven/MavenTestDataPublisher.java Christoph Kutzinski : 20bd2fcad1040a72e1b331b622c063bf2e36256b Files : changelog.html

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/maven/MavenTestDataPublisher.java
          http://jenkins-ci.org/commit/maven-plugin/5f3364ef927cfc602d5a25a94974c4062e3aeb5b
          Log:
          JENKINS-14585 MavenTestDataPublisher didn't do anything
          Originally-Committed-As: 8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/maven/MavenTestDataPublisher.java http://jenkins-ci.org/commit/maven-plugin/5f3364ef927cfc602d5a25a94974c4062e3aeb5b Log: JENKINS-14585 MavenTestDataPublisher didn't do anything Originally-Committed-As: 8d246cbf9de8ed1ad1ec4256f814e7b40fe0e419

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/maven/MavenTestDataPublisher.java
          http://jenkins-ci.org/commit/maven-plugin/2ca3d0b1dd84e761f9f547703a2d795f4d3382f8
          Log:
          Merge pull request #810 from kutzi/claim-plugin-fix

          JENKINS-14585 core side fix for: claim-plugin cannot claim broken tests in maven jobs
          Originally-Committed-As: 84ee0de3238e811a4f2df94ed7e2cda7518f246f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/maven/MavenTestDataPublisher.java http://jenkins-ci.org/commit/maven-plugin/2ca3d0b1dd84e761f9f547703a2d795f4d3382f8 Log: Merge pull request #810 from kutzi/claim-plugin-fix JENKINS-14585 core side fix for: claim-plugin cannot claim broken tests in maven jobs Originally-Committed-As: 84ee0de3238e811a4f2df94ed7e2cda7518f246f

            ki82 Christian Bremer
            sroth Steve Roth
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: