Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14617

libvirt-slave builds broken connection URI

XMLWordPrintable

      When building the connection URI in Hypervisor.java, the query parameter "?no_tty=1" is always appended. This does not take into account, that users might already have added their own parameters in the advanced settings already.

      E.g: In order to use a different SSH-key location and disable host-key verification, I use the following Hypervisor-System-URL:

      system?keyfile=/etc/jenkins/id_dsa_remoting&no_verify=1

      The attached patch fixes this by using '&' resp. '?' conditionally.

      Please note, that the patch also contains an update in the (rather old) plugin's pom.xml to make it build with current jenkins (and JDK 1.7).

        1. libvirt-slave-uri-querystring.patch
          2 kB

          [JENKINS-14617] libvirt-slave builds broken connection URI

          Fritz Elfert created issue -
          Philipp Bartsch made changes -
          Assignee Original: mmornati [ mmornati ] New: Philipp Bartsch [ tastybug ]
          Philipp Bartsch made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tastybug
          Path:
          src/main/java/hudson/plugins/libvirt/Hypervisor.java
          http://jenkins-ci.org/commit/libvirt-slave-plugin/a9c654c3fd3636c79f6532f6e52e4fd05ab0a602
          Log:
          -Fixing JENKINS-14617

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tastybug Path: src/main/java/hudson/plugins/libvirt/Hypervisor.java http://jenkins-ci.org/commit/libvirt-slave-plugin/a9c654c3fd3636c79f6532f6e52e4fd05ab0a602 Log: -Fixing JENKINS-14617

          Philipp Bartsch added a comment -

          Fixed in 1.7

          Philipp Bartsch added a comment - Fixed in 1.7
          Philipp Bartsch made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          G. Kr. added a comment -

          closing as fixed

          G. Kr. added a comment - closing as fixed
          G. Kr. made changes -
          Status Original: Resolved [ 5 ] New: Closed [ 6 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 145313 ] New: JNJira + In-Review [ 206023 ]

            tastybug Philipp Bartsch
            felfert Fritz Elfert
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: