Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14711

Polling and Changelog do not pick up changes on CVS Tags

    • Icon: Bug Bug
    • Resolution: Won't Fix
    • Icon: Major Major
    • cvs-plugin
    • None

      When creating a job using a cvs branch, and cvs plugin does the checkout and rlog, but finds nothing. Using the same parameters from the commandline, using linux cvs client, it does see the changes.

      From the log:
      cvs rlog -S -d07 Aug 2012 17:47:11 +0300<07 Aug 2012 18:12:20 +0300 base-iso
      cvs rlog: Logging base-iso
      cvs rlog: Logging base-iso/.disk
      cvs rlog: Logging base-iso/boot

      but from the commandline:
      cvs rlog -S -d"07 Aug 2012 17:47:11 +0300<07 Aug 2012 18:12:20 +0300" base-iso
      cvs rlog: Logging base-iso

      RCS file: /opt/cvsroot/base-iso/create_iso.sh,v
      head: 1.6
      branch:
      locks: strict
      access list:
      symbolic names:
      keyword substitution: kv
      total revisions: 6; selected revisions: 1
      description:
      ----------------------------
      revision 1.6
      date: 2012/08/07 14:47:55; author: urim; state: Exp; lines: +1 -1
      Changelog
      =============================================================================
      cvs rlog: Logging base-iso/.disk
      cvs rlog: Logging base-iso/boot
      cvs rlog: Logging base-iso/boot/grub

      After downgrading to CVS plugin 1.6, the changes list is working, so it seems to be a problem with the cvs library.

          [JENKINS-14711] Polling and Changelog do not pick up changes on CVS Tags

          uri milman created issue -

          It looks to be a regression from 2.4. I have just downgraded from 2.5 to 2.4 and it is working again.

          Michel Graciano added a comment - It looks to be a regression from 2.4. I have just downgraded from 2.5 to 2.4 and it is working again.

          I have one installation with version 2.5 of plugin (Jenkins 1.477) and it is not possible to downgrade to 2.4 but only to 1.6 from the jenkins manager console. Is there any workarround to get it working before we have the issue solved?

          Leonardo Soares added a comment - I have one installation with version 2.5 of plugin (Jenkins 1.477) and it is not possible to downgrade to 2.4 but only to 1.6 from the jenkins manager console. Is there any workarround to get it working before we have the issue solved?

          I have found the error and created a patch at https://github.com/mgraciano/cvs-plugin/commit/acda8d6d6cc9053f770ae765c497a6396b860b9f

          It was a parsing pattern issue, so i fixed to revert to the original parsing and created a workaround to parse the current date. The problem is just for visualization, the changelog is created successfully. How can I send the patch to you? Should I create a pull request?

          Michel Graciano added a comment - I have found the error and created a patch at https://github.com/mgraciano/cvs-plugin/commit/acda8d6d6cc9053f770ae765c497a6396b860b9f It was a parsing pattern issue, so i fixed to revert to the original parsing and created a workaround to parse the current date. The problem is just for visualization, the changelog is created successfully. How can I send the patch to you? Should I create a pull request?

          BTW, the workaround is to fix the changelog.xml files manually. Just change de <changeDate> to use - instead / as date fields separator. Maybe a shell script could help.

          Michel Graciano added a comment - BTW, the workaround is to fix the changelog.xml files manually. Just change de <changeDate> to use - instead / as date fields separator. Maybe a shell script could help.
          Michel Graciano made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Michel Graciano made changes -
          Status Original: In Progress [ 3 ] New: Open [ 1 ]

          I have updated my patch and create tests to avoid this kind of regression again as well to verify the patch.

          https://github.com/mgraciano/cvs-plugin/commits/master

          Should I start a pull request for this?

          Michel Graciano added a comment - I have updated my patch and create tests to avoid this kind of regression again as well to verify the patch. https://github.com/mgraciano/cvs-plugin/commits/master Should I start a pull request for this?

          Michel Graciano added a comment - Pull request created https://github.com/jenkinsci/cvs-plugin/pull/14

          Code changed in jenkins
          User: mgraciano
          Path:
          src/main/java/hudson/scm/CVSChangeLogSet.java
          http://jenkins-ci.org/commit/cvs-plugin/acda8d6d6cc9053f770ae765c497a6396b860b9f
          Log:
          JENKINS-14711 - No changelist in CVS plugin 2.5 using rlog, but "cli rlog" works fine

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: mgraciano Path: src/main/java/hudson/scm/CVSChangeLogSet.java http://jenkins-ci.org/commit/cvs-plugin/acda8d6d6cc9053f770ae765c497a6396b860b9f Log: JENKINS-14711 - No changelist in CVS plugin 2.5 using rlog, but "cli rlog" works fine

            mc1arke Michael Clarke
            milman uri milman
            Votes:
            3 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved: