Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15094

Parameters: NPE in canTake() procedures may kill all executors

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • core
    • Jenkins ver. 1.466.1
      Linux buildserver 2.6.18-164.11.1.el5PAE #1 SMP Wed Jan 6 13:43:57 EST 2010 i686 i686 i386 GNU/Linux

      Jenkins executors are not robust against nulls returned by createValue() and createDefaultValue(). Such return value is valid according to Javadoc.

      NPE in canTake() procedure kills the executor thread. Unfortunately, Jenkins tries other executors after that => any NPE in canTake() terminates ALL active Jenkins executors.

      The initial description from Rotem:

      when using jenkins-multijob-plugin and parameter from type “File Parameter” the Jenkins crashes.
      When i start to run a Multijob with a multijob phase with values in "Advanced: "parameters", if the next job has a parameter from type “File Parameter” Jenkins is eating up all the executers with - ALL available Build executors are turning into zombies with the status 'Dead ' with the exception:

      java.lang.NullPointerException
      at hudson.model.ParametersAction.getAssignedLabel(ParametersAction.java:126)
      at hudson.model.Queue$Item.getAssignedLabel(Queue.java:1265)
      at hudson.model.Node.canTake(Node.java:308)
      at hudson.model.Queue$JobOffer.canTake(Queue.java:210)
      at hudson.model.Queue.maintain(Queue.java:952)
      at hudson.model.Queue.pop(Queue.java:783)
      at hudson.model.Executor.grabJob(Executor.java:287)
      at hudson.model.Executor.run(Executor.java:208)

      Even if at this stage I go to the settings and enlarge the number of Executors, they immediately turn into zombies as well.
      When I remove the specific “File Parameter” parameter all works fine.
      Please advice.

          [JENKINS-15094] Parameters: NPE in canTake() procedures may kill all executors

          Rotem G created issue -
          Rotem G made changes -
          Link New: This issue is related to JENKINS-15036 [ JENKINS-15036 ]
          hagzag made changes -
          Assignee New: itai Or [ itaior ]
          itai Or made changes -
          Fix Version/s New: current [ 10162 ]
          Resolution New: Cannot Reproduce [ 5 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Oleg Nenashev made changes -
          Assignee Original: itai Or [ itaior ] New: Oleg Nenashev [ oleg_nenashev ]
          Resolution Original: Cannot Reproduce [ 5 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          Oleg Nenashev made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: jenkins-multijob-plugin [ 16545 ]
          Priority Original: Major [ 3 ] New: Blocker [ 1 ]
          Summary Original:  Multijob with use of parameter from type “File Parameter” all Executors are becoming Dead (!) New:  Massive jobs with “File Parameters” may kill all executors by NPE in canTake() procedures
          Oleg Nenashev made changes -
          Link New: This issue is related to JENKINS-22925 [ JENKINS-22925 ]
          Oleg Nenashev made changes -
          Component/s New: parameters [ 15594 ]
          Description Original: when using jenkins-multijob-plugin and parameter from type “File Parameter” the Jenkins crashes.
          When i start to run a Multijob with a multijob phase with values in "Advanced: "parameters", if the next job has a parameter from type “File Parameter” Jenkins is eating up all the executers with - ALL available Build executors are turning into zombies with the status 'Dead ' with the exception:

          java.lang.NullPointerException
          at hudson.model.ParametersAction.getAssignedLabel(ParametersAction.java:126)
          at hudson.model.Queue$Item.getAssignedLabel(Queue.java:1265)
          at hudson.model.Node.canTake(Node.java:308)
          at hudson.model.Queue$JobOffer.canTake(Queue.java:210)
          at hudson.model.Queue.maintain(Queue.java:952)
          at hudson.model.Queue.pop(Queue.java:783)
          at hudson.model.Executor.grabJob(Executor.java:287)
          at hudson.model.Executor.run(Executor.java:208)

          Even if at this stage I go to the settings and enlarge the number of Executors, they immediately turn into zombies as well.
          When I remove the specific “File Parameter” parameter all works fine.
          Please advice.

          New: Jenkins executors are not robust against nulls returned by createValue() and createDefaultValue(). Such return value is valid according to Javadoc.

          NPE in canTake() procedure kills the executor thread. Unfortunately, Jenkins tries other executors after that => any NPE in canTake() terminates ALL active Jenkins executors.

          The initial description from Rotem:
          {quote}
          when using jenkins-multijob-plugin and parameter from type “File Parameter” the Jenkins crashes.
          When i start to run a Multijob with a multijob phase with values in "Advanced: "parameters", if the next job has a parameter from type “File Parameter” Jenkins is eating up all the executers with - ALL available Build executors are turning into zombies with the status 'Dead ' with the exception:

          java.lang.NullPointerException
          at hudson.model.ParametersAction.getAssignedLabel(ParametersAction.java:126)
          at hudson.model.Queue$Item.getAssignedLabel(Queue.java:1265)
          at hudson.model.Node.canTake(Node.java:308)
          at hudson.model.Queue$JobOffer.canTake(Queue.java:210)
          at hudson.model.Queue.maintain(Queue.java:952)
          at hudson.model.Queue.pop(Queue.java:783)
          at hudson.model.Executor.grabJob(Executor.java:287)
          at hudson.model.Executor.run(Executor.java:208)

          Even if at this stage I go to the settings and enlarge the number of Executors, they immediately turn into zombies as well.
          When I remove the specific “File Parameter” parameter all works fine.
          Please advice.
          {quote}

          Summary Original:  Massive jobs with “File Parameters” may kill all executors by NPE in canTake() procedures New: Parameters: NPE in canTake() procedures may kill all executors
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Reopened [ 4 ] New: Resolved [ 5 ]
          Oleg Nenashev made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.565.1-fixed

            oleg_nenashev Oleg Nenashev
            rotem Rotem G
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: