Details
-
Type:
Bug
-
Status: Resolved (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: mercurial-plugin
-
Labels:None
-
Similar Issues:
Description
See pull request @ https://github.com/jenkinsci/mercurial-plugin/pull/31
Currently it appears that the Mercurial plugin doesn't check the exit code of the hg pull used to update the repository (see hudson.plugins.mercurial.MercurialSCM#update() - https://github.com/jenkinsci/mercurial-plugin/blob/master/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L496)
So, if the upstream repo has gone away for some reason (say, hypothetically, I've rm-ed it), the hg pull will fail and exit with a status code of 255, but the build will continue regardless
Attachments
Issue Links
- is duplicated by
-
JENKINS-22092 Failed hg pulls do not report failure
-
- Resolved
-
Activity
Field | Original Value | New Value |
---|---|---|
Status | Open [ 1 ] | In Progress [ 3 ] |
Description |
Currently it appears that the Mercurial plugin doesn't check the exit code of the {{hg pull}} used to update the repository (see {{hudson.plugins.mercurial.MercurialSCM#update()}} - https://github.com/jenkinsci/mercurial-plugin/blob/master/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L496) So, if the upstream repo has gone away for some reason (say, hypothetically, I've rm-ed it), the {{hg pull}} will fail and exit with a status code of 255, but the build will continue regardless |
See pull request @ https://github.com/jenkinsci/mercurial-plugin/pull/31 Currently it appears that the Mercurial plugin doesn't check the exit code of the {{hg pull}} used to update the repository (see {{hudson.plugins.mercurial.MercurialSCM#update()}} - https://github.com/jenkinsci/mercurial-plugin/blob/master/src/main/java/hudson/plugins/mercurial/MercurialSCM.java#L496) So, if the upstream repo has gone away for some reason (say, hypothetically, I've rm-ed it), the {{hg pull}} will fail and exit with a status code of 255, but the build will continue regardless |
Assignee | Jesse Glick [ jglick ] | Rene Kroon [ sioux ] |
Resolution | Fixed [ 1 ] | |
Status | In Progress [ 3 ] | Resolved [ 5 ] |
Link |
This issue is duplicated by |
Assignee | Rene Kroon [ sioux ] | Jesse Glick [ jglick ] |
Resolution | Fixed [ 1 ] | |
Status | Resolved [ 5 ] | Reopened [ 4 ] |
Resolution | Fixed [ 1 ] | |
Status | Reopened [ 4 ] | Resolved [ 5 ] |
Workflow | JNJira [ 146607 ] | JNJira + In-Review [ 192001 ] |
Note that this also affects repositories that need to be recovered (using 'hg recover'). Currently Jenkins just builds the last change that was pulled before the repository got in a bad state. This way it is very hard to see that this is the issue. Checking the exit code and stopping would make it easy to replay by hand at the right point in the build.