Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15882

rebuild plugin should not store non-stored password parameter

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I have a job with store non-stored password parameter. When trying to rebuild the job, password is stored.

      Expected results:
      The rebuild plugin should not keep passwords. When clicking on rebuild button, it should promt for password once again.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          10 older comments
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rino
          Path:
          src/main/java/com/sonyericsson/rebuild/RebuildAction.java
          src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html
          http://jenkins-ci.org/commit/rebuild-plugin/0eb0c0005525327e3818c4b961ab65da28fcd75d
          Log:
          JENKINS-15882 - rebuild plugin should not store non-stored password parameter
          -Replaced if jelly tag by choose
          -fixed global jelly to show documentation
          -imrpoved documentation
          -added license
          -added javadoc

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rino Path: src/main/java/com/sonyericsson/rebuild/RebuildAction.java src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html http://jenkins-ci.org/commit/rebuild-plugin/0eb0c0005525327e3818c4b961ab65da28fcd75d Log: JENKINS-15882 - rebuild plugin should not store non-stored password parameter -Replaced if jelly tag by choose -fixed global jelly to show documentation -imrpoved documentation -added license -added javadoc
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rino
          Path:
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
          http://jenkins-ci.org/commit/rebuild-plugin/690ac040b745e95de347e429d9ed23c2312374b5
          Log:
          JENKINS-15882 - rebuild plugin should not store non-stored password parameter
          -added default true

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rino Path: src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly http://jenkins-ci.org/commit/rebuild-plugin/690ac040b745e95de347e429d9ed23c2312374b5 Log: JENKINS-15882 - rebuild plugin should not store non-stored password parameter -added default true
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rino
          Path:
          .gitignore
          src/main/java/com/sonyericsson/rebuild/RebuildAction.java
          src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
          src/main/java/com/sonyericsson/rebuild/RebuildDescriptor.java
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/config.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/help-rememberPasswordEnabled.html
          http://jenkins-ci.org/commit/rebuild-plugin/6678b8e297661bdbb83649280546d927ea06c617
          Log:
          JENKINS-15882 - rebuild plugin should not store non-stored password parameter

          • fixed review comment
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rino Path: .gitignore src/main/java/com/sonyericsson/rebuild/RebuildAction.java src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java src/main/java/com/sonyericsson/rebuild/RebuildDescriptor.java src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly src/main/resources/com/sonyericsson/rebuild/RebuildAction/global.jelly src/main/resources/com/sonyericsson/rebuild/RebuildAction/help-rememberPassword.html src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/config.jelly src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/help-rememberPasswordEnabled.html http://jenkins-ci.org/commit/rebuild-plugin/6678b8e297661bdbb83649280546d927ea06c617 Log: JENKINS-15882 - rebuild plugin should not store non-stored password parameter fixed review comment
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Robert Sandell
          Path:
          .gitignore
          src/main/java/com/sonyericsson/rebuild/RebuildAction.java
          src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java
          src/main/java/com/sonyericsson/rebuild/RebuildDescriptor.java
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/ExtendedChoiceParameterValue.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/config.jelly
          src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/help-rememberPasswordEnabled.html
          http://jenkins-ci.org/commit/rebuild-plugin/50f9bf384cbca8125c9eefc8f48c132ee1a71247
          Log:
          Merge pull request #8 from rinokadijk/master

          Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter

          Compare: https://github.com/jenkinsci/rebuild-plugin/compare/d7bc0e5155ed...50f9bf384cbc

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: .gitignore src/main/java/com/sonyericsson/rebuild/RebuildAction.java src/main/java/com/sonyericsson/rebuild/RebuildConfiguration.java src/main/java/com/sonyericsson/rebuild/RebuildDescriptor.java src/main/resources/com/sonyericsson/rebuild/RebuildAction/ExtendedChoiceParameterValue.jelly src/main/resources/com/sonyericsson/rebuild/RebuildAction/PasswordParameterValue.jelly src/main/resources/com/sonyericsson/rebuild/RebuildAction/parameterized.jelly src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/config.jelly src/main/resources/com/sonyericsson/rebuild/RebuildDescriptor/help-rememberPasswordEnabled.html http://jenkins-ci.org/commit/rebuild-plugin/50f9bf384cbca8125c9eefc8f48c132ee1a71247 Log: Merge pull request #8 from rinokadijk/master Fixed JENKINS-15882 - rebuild plugin should not store non-stored password parameter Compare: https://github.com/jenkinsci/rebuild-plugin/compare/d7bc0e5155ed...50f9bf384cbc
          Hide
          Permalink
          walterk82 Walter Kacynski added a comment -

          I've tested this and it works great.

          Show
          walterk82 Walter Kacynski added a comment - I've tested this and it works great.

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            knesenko Kiril Nesenko
            Votes:
            3 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: