Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16572

Optimize http requests for static resources in the disk usage plugin

XMLWordPrintable

      By using the firebug add-on in firefox, we can see that there are unnecessary http requests for the static resources of the disk usage plugin.

      For example, for every display of the home page https://builds.apache.org/
      there is unnecessary http request for diskusage48.png (see "jenkins home page.png"). The browser should know that this is useless to ask.

      According to https://groups.google.com/forum/#!msg/jenkinsci-dev/qQf7Tuu6uiw/_WO7OBj_LIkJ
      this can be fixed by using "Jenkins.getResourcePath()" or ${resURL}.

      Firebug can be used locally to check the changes.

        1. jenkins home page.png
          jenkins home page.png
          21 kB

          [JENKINS-16572] Optimize http requests for static resources in the disk usage plugin

          evernat created issue -
          evernat made changes -
          Link New: This issue is related to JENKINS-16571 [ JENKINS-16571 ]

          evernat added a comment -

          I have just seen JENKINS-16530.
          Would it better with that?

          evernat added a comment - I have just seen JENKINS-16530 . Would it better with that?

          Jesse Glick added a comment -

          @evernat the fix JENKINS-16530 may or may not help here; I think it would help for DiskUsageRootLink (check it using a Jenkins dev build). For DiskUsageManagementLink I think there is no problem since Jenkins/manage.jelly has long used resURL.

          0a805e7 also was an earlier improvement.

          Jesse Glick added a comment - @evernat the fix JENKINS-16530 may or may not help here; I think it would help for DiskUsageRootLink (check it using a Jenkins dev build). For DiskUsageManagementLink I think there is no problem since Jenkins/manage.jelly has long used resURL . 0a805e7 also was an earlier improvement.

          evernat added a comment -

          After tests with Jenkins v1.502, this issue was fixed by JENKINS-16530.
          So resolving as fixed.

          evernat added a comment - After tests with Jenkins v1.502, this issue was fixed by JENKINS-16530 . So resolving as fixed.
          evernat made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Jesse Glick made changes -
          Link New: This issue duplicates JENKINS-16530 [ JENKINS-16530 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 147395 ] New: JNJira + In-Review [ 192381 ]

            vjuranek vjuranek
            evernat evernat
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: