Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16851

Strategy GerritTrigger missing with git plugin 1.1.28

      After upgrading to git plugin 1.1.28 the GerritTrigger strategy is not available anymore, all gerrit trigger jobs fail.

          [JENKINS-16851] Strategy GerritTrigger missing with git plugin 1.1.28

          After reverting git-plugin to 1.1.26 everything is back to normal here. The change was introduced in git 1.1.27, 1.1.28 was just a minor bugfix.

          Björn Pedersen added a comment - After reverting git-plugin to 1.1.26 everything is back to normal here. The change was introduced in git 1.1.27, 1.1.28 was just a minor bugfix.

          Marcel Huber added a comment -

          Thank you Björn, I did not step back in git-plugin versions so I missed this one, sorry.

          Marcel Huber added a comment - Thank you Björn, I did not step back in git-plugin versions so I missed this one, sorry.

          rsandell added a comment -

          The git plugin beats me again

          I've managed to fix the incompatibility, and in the process I happened to fix the changelog issue in GT as well.
          But that introduced an infinite loop between the git plugin and Mailer in core when the culprits are being calculated at the end of the build.
          From the looks of it it does not have to do with my changes, but I need to dive into it more before I let it loose in the wild.

          rsandell added a comment - The git plugin beats me again I've managed to fix the incompatibility, and in the process I happened to fix the changelog issue in GT as well. But that introduced an infinite loop between the git plugin and Mailer in core when the culprits are being calculated at the end of the build. From the looks of it it does not have to do with my changes, but I need to dive into it more before I let it loose in the wild.

          Jesse Glick added a comment -

          Jesse Glick added a comment - https://wiki.jenkins-ci.org/display/JENKINS/Git+Plugin claims this is fixed in 1.1.29.

          rsandell added a comment -

          I probably need to do some changes in the Gerrit Trigger as well, because the current code assumes that the IGitApi reference is something else (by casting it) so that it can do some log parsing. And with the new git api implementation that assumption is wrong.

          rsandell added a comment - I probably need to do some changes in the Gerrit Trigger as well, because the current code assumes that the IGitApi reference is something else (by casting it) so that it can do some log parsing. And with the new git api implementation that assumption is wrong.

          Björn Pedersen added a comment - The infinite loop could be: https://issues.jenkins-ci.org/browse/JENKINS-16849

          rsandell added a comment -

          Yes that looks very similar.

          rsandell added a comment - Yes that looks very similar.

          Code changed in jenkins
          User: rsandell
          Path:
          gerrithudsontrigger/pom.xml
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/65271af7819f62d258ec1cadd70434129bf299c9
          Log:
          Fix For JENKINS-16851

          It is probably fixed in git plugin v. 1.1.29
          this commit should remove any use of deprecated APIs.
          But when I test this I gen something very similar to
          JENKINS-16849 at the end of the build.


          You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
          To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
          For more options, visit https://groups.google.com/groups/opt_out.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: rsandell Path: gerrithudsontrigger/pom.xml gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/65271af7819f62d258ec1cadd70434129bf299c9 Log: Fix For JENKINS-16851 It is probably fixed in git plugin v. 1.1.29 this commit should remove any use of deprecated APIs. But when I test this I gen something very similar to JENKINS-16849 at the end of the build. – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .

          Code changed in jenkins
          User: Robert Sandell
          Path:
          gerrithudsontrigger/pom.xml
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/155ab6790a33b6f0b229976a40f5ee5f64d1ce22
          Log:
          Removed use of deprecated APIs for git BuildChooser

          Followup fix for JENKINS-16851 which is fixed in git plugin v. 1.2.0
          this commit should remove any use of deprecated APIs after the
          introduction of gitclient plugin.

          Change-Id: Ibaa11fe9e06150555af675aae1a32f29cb15aab3

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: gerrithudsontrigger/pom.xml gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritTriggerBuildChooser.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/155ab6790a33b6f0b229976a40f5ee5f64d1ce22 Log: Removed use of deprecated APIs for git BuildChooser Followup fix for JENKINS-16851 which is fixed in git plugin v. 1.2.0 this commit should remove any use of deprecated APIs after the introduction of gitclient plugin. Change-Id: Ibaa11fe9e06150555af675aae1a32f29cb15aab3

          rsandell added a comment -

          Released in
          Git Plugin 1.2.0
          Gerrit Trigger Plugin 2.8.0

          rsandell added a comment - Released in Git Plugin 1.2.0 Gerrit Trigger Plugin 2.8.0

            rsandell rsandell
            pedersen Björn Pedersen
            Votes:
            4 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: