Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17050

popup does not close when clicking outside its area

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Trivial
    • Resolution: Fixed
    • core
    • None
    • Jenkins 1.501; Safari 6.0.2; MacOSX 10.8.2

    Description

      The popup which is opened by a hetero-list-add button does not close when clicking outside its area. You have to click to the button again to close it.

      Expected: Clicking anywhere outside the popup should close it.

      Example: The "Add build step" button in Job configuration screen

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          marc_guenther Marc Günther created issue -
          chrisa89 Chris Arnott made changes -
          Field Original Value New Value
          Assignee Chris Arnott [ chrisa89 ]
          chrisa89 Chris Arnott made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          chrisa89 Chris Arnott added a comment -

          Pull request created: https://github.com/jenkinsci/jenkins/pull/1038

          chrisa89 Chris Arnott added a comment - Pull request created: https://github.com/jenkinsci/jenkins/pull/1038
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Chris Arnott
          Path:
          war/src/main/webapp/scripts/yui/button/button-debug.js
          war/src/main/webapp/scripts/yui/button/button-min.js
          http://jenkins-ci.org/commit/jenkins/0b49ff91fc2aeec7a68b26174e04c5908609051f
          Log:
          [FIXED JENKINS-17050] Close pop-up menu when clicking outside.

          The _activationButtonPressed get's set to false onMouseUp, so can not be used to decide if the menu is active or not.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Chris Arnott Path: war/src/main/webapp/scripts/yui/button/button-debug.js war/src/main/webapp/scripts/yui/button/button-min.js http://jenkins-ci.org/commit/jenkins/0b49ff91fc2aeec7a68b26174e04c5908609051f Log: [FIXED JENKINS-17050] Close pop-up menu when clicking outside. The _activationButtonPressed get's set to false onMouseUp, so can not be used to decide if the menu is active or not.
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Resolved [ 5 ]
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3326
          [FIXED JENKINS-17050] Close pop-up menu when clicking outside. (Revision 0b49ff91fc2aeec7a68b26174e04c5908609051f)

          Result = SUCCESS
          kohsuke : 0b49ff91fc2aeec7a68b26174e04c5908609051f
          Files :

          • war/src/main/webapp/scripts/yui/button/button-min.js
          • war/src/main/webapp/scripts/yui/button/button-debug.js
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3326 [FIXED JENKINS-17050] Close pop-up menu when clicking outside. (Revision 0b49ff91fc2aeec7a68b26174e04c5908609051f) Result = SUCCESS kohsuke : 0b49ff91fc2aeec7a68b26174e04c5908609051f Files : war/src/main/webapp/scripts/yui/button/button-min.js war/src/main/webapp/scripts/yui/button/button-debug.js
          danielbeck Daniel Beck made changes -
          Component/s core [ 15593 ]
          Component/s ui-changes [ 16530 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 147881 ] JNJira + In-Review [ 192625 ]

          People

            chrisa89 Chris Arnott
            marc_guenther Marc Günther
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: