Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17050

popup does not close when clicking outside its area

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • core
    • None
    • Jenkins 1.501; Safari 6.0.2; MacOSX 10.8.2

      The popup which is opened by a hetero-list-add button does not close when clicking outside its area. You have to click to the button again to close it.

      Expected: Clicking anywhere outside the popup should close it.

      Example: The "Add build step" button in Job configuration screen

          [JENKINS-17050] popup does not close when clicking outside its area

          Chris Arnott added a comment -

          Chris Arnott added a comment - Pull request created: https://github.com/jenkinsci/jenkins/pull/1038

          Code changed in jenkins
          User: Chris Arnott
          Path:
          war/src/main/webapp/scripts/yui/button/button-debug.js
          war/src/main/webapp/scripts/yui/button/button-min.js
          http://jenkins-ci.org/commit/jenkins/0b49ff91fc2aeec7a68b26174e04c5908609051f
          Log:
          [FIXED JENKINS-17050] Close pop-up menu when clicking outside.

          The _activationButtonPressed get's set to false onMouseUp, so can not be used to decide if the menu is active or not.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Chris Arnott Path: war/src/main/webapp/scripts/yui/button/button-debug.js war/src/main/webapp/scripts/yui/button/button-min.js http://jenkins-ci.org/commit/jenkins/0b49ff91fc2aeec7a68b26174e04c5908609051f Log: [FIXED JENKINS-17050] Close pop-up menu when clicking outside. The _activationButtonPressed get's set to false onMouseUp, so can not be used to decide if the menu is active or not.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3326
          [FIXED JENKINS-17050] Close pop-up menu when clicking outside. (Revision 0b49ff91fc2aeec7a68b26174e04c5908609051f)

          Result = SUCCESS
          kohsuke : 0b49ff91fc2aeec7a68b26174e04c5908609051f
          Files :

          • war/src/main/webapp/scripts/yui/button/button-min.js
          • war/src/main/webapp/scripts/yui/button/button-debug.js

          dogfood added a comment - Integrated in jenkins_main_trunk #3326 [FIXED JENKINS-17050] Close pop-up menu when clicking outside. (Revision 0b49ff91fc2aeec7a68b26174e04c5908609051f) Result = SUCCESS kohsuke : 0b49ff91fc2aeec7a68b26174e04c5908609051f Files : war/src/main/webapp/scripts/yui/button/button-min.js war/src/main/webapp/scripts/yui/button/button-debug.js

            chrisa89 Chris Arnott
            marc_guenther Marc Günther
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: