Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17108

No events fired when user selects enable and disable project button

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • core
    • ubuntu quantal
      jenkins ver 1.502

    Description

      The jenkins ItemListener does not fire events when user clicks on the button to disable and enable a project. That button should at least fire an onUpdated event.

      Attachments

        Activity

          kstutz Kathi Stutz added a comment -

          I just noticed this as well. It also doesn't fire when you change the description of a project using the "edit description" textbox on the project page. This is a pity, because it renders the onUpdated() method of ItemListener useless for me. (We'll use the SaveableListener as a workaround.)

          kstutz Kathi Stutz added a comment - I just noticed this as well. It also doesn't fire when you change the description of a project using the "edit description" textbox on the project page. This is a pity, because it renders the onUpdated() method of ItemListener useless for me. (We'll use the SaveableListener as a workaround.)

          If I have time I will create a pull request for this tonight, it's an easy fix, only two lines of code.

          red_nuht Daniel Olausson added a comment - If I have time I will create a pull request for this tonight, it's an easy fix, only two lines of code.

          Code changed in jenkins
          User: Daniel Olausson
          Path:
          core/src/main/java/hudson/model/AbstractItem.java
          core/src/main/java/hudson/model/AbstractProject.java
          http://jenkins-ci.org/commit/jenkins/e81a9076c414eda983559f17aa8f0c38b8a89b09
          Log:
          JENKINS-17108. This solves the problem with ItemListner.onUpdated not being called if the project was disabled/enabled by pushing the button on the project page. Also solved the problem with ItemListener.onUpdated not getting called if the project description was updated using the edit description on the project page.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Olausson Path: core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/AbstractProject.java http://jenkins-ci.org/commit/jenkins/e81a9076c414eda983559f17aa8f0c38b8a89b09 Log: JENKINS-17108 . This solves the problem with ItemListner.onUpdated not being called if the project was disabled/enabled by pushing the button on the project page. Also solved the problem with ItemListener.onUpdated not getting called if the project description was updated using the edit description on the project page.
          vjuranek vjuranek added a comment -

          Now, should be fixed by PR #912

          vjuranek vjuranek added a comment - Now, should be fixed by PR #912
          zaro Khai Do added a comment -

          I have verified that has been fixed in LTS ver 1.565.3

          zaro Khai Do added a comment - I have verified that has been fixed in LTS ver 1.565.3
          zaro Khai Do added a comment -

          works in LTS ver 1.565.3

          zaro Khai Do added a comment - works in LTS ver 1.565.3

          People

            Unassigned Unassigned
            zaro Khai Do
            Votes:
            2 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: