Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17290

Category titles in Available Plugins list appear wrong in reverse sort order

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Trivial Trivial
    • core
    • None

      A very tiny detail, but...

      In the Plugin Manager in the Available list:
      https://jenkins.local/pluginManager/available
      the plugins are grouped into categories, each category has a title (eg. "Artifact Uploaders)

      When I now revert the sort order by clicking on the "Install" header, the category title appears BELOW its plugins, and not above.

          [JENKINS-17290] Category titles in Available Plugins list appear wrong in reverse sort order

          evernat added a comment - - edited

          reproduced with Jenkins 1.553 with Firefox

          evernat added a comment - - edited reproduced with Jenkins 1.553 with Firefox

          Ruoxi Jiang added a comment -

          Issues is fixed.
          Waiting for pull request to be accepted. #1741

          Ruoxi Jiang added a comment - Issues is fixed. Waiting for pull request to be accepted. #1741

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - Resubmitted as https://github.com/jenkinsci/jenkins/pull/1708

          Code changed in jenkins
          User: ruoxijiang
          Path:
          war/src/main/webapp/scripts/sortable.js
          http://jenkins-ci.org/commit/jenkins/d739bedc0d5cc42aa28868fa28a709081460671c
          Log:
          [FIXED JENKINS-17290] - Corrected sort order of tables
          ---------
          It seems that the sort is for sorting ascending order, thus a
          "descending" order should be sorter.reverse (+1 squashed commit)
          Squashed commits:
          [a5eb304] [FIXED JENKINS-17290]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ruoxijiang Path: war/src/main/webapp/scripts/sortable.js http://jenkins-ci.org/commit/jenkins/d739bedc0d5cc42aa28868fa28a709081460671c Log: [FIXED JENKINS-17290] - Corrected sort order of tables --------- It seems that the sort is for sorting ascending order, thus a "descending" order should be sorter.reverse (+1 squashed commit) Squashed commits: [a5eb304] [FIXED JENKINS-17290]

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          war/src/main/webapp/scripts/sortable.js
          http://jenkins-ci.org/commit/jenkins/9cb9a8f63fcab3f909288c9e95d23e68e94d5b2b
          Log:
          Merge pull request #1708 from oleg-nenashev/JENKINS-17290-fix

          [FIXED JENKINS-17290] - Corrected sort order of tables

          Compare: https://github.com/jenkinsci/jenkins/compare/216d3355a256...9cb9a8f63fca

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: war/src/main/webapp/scripts/sortable.js http://jenkins-ci.org/commit/jenkins/9cb9a8f63fcab3f909288c9e95d23e68e94d5b2b Log: Merge pull request #1708 from oleg-nenashev/ JENKINS-17290 -fix [FIXED JENKINS-17290] - Corrected sort order of tables Compare: https://github.com/jenkinsci/jenkins/compare/216d3355a256...9cb9a8f63fca

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4155

          Result = UNSTABLE

          dogfood added a comment - Integrated in jenkins_main_trunk #4155 Result = UNSTABLE

          Daniele Vigano added a comment - - edited

          After this fix, the default job list sort in the main page is reversed (Z -> A instead of A -> Z)

          Daniele Vigano added a comment - - edited After this fix, the default job list sort in the main page is reversed (Z -> A instead of A -> Z)

          Inverted order in the job list

          Daniele Vigano added a comment - Inverted order in the job list

          Daniel Beck added a comment -

          Isn't that a session cookie or something from the last time you reordered the list? What happens when you open Jenkins in private browsing mode?

          Daniel Beck added a comment - Isn't that a session cookie or something from the last time you reordered the list? What happens when you open Jenkins in private browsing mode?

          Yes, I've already tried with incognito browsing and across different browsers with the same result. For a second the list is displayed in the right sort, but then when the page has been fully loaded the sort order is inverted. Previously it was working fine and reverting JENKINS-17290 fixes the problem.

          Daniele Vigano added a comment - Yes, I've already tried with incognito browsing and across different browsers with the same result. For a second the list is displayed in the right sort, but then when the page has been fully loaded the sort order is inverted. Previously it was working fine and reverting JENKINS-17290 fixes the problem.

          Daniel Beck added a comment - - edited

          daniviga Could you please file a new issue, link it to this one, and label it regression? Thanks!

          Daniel Beck added a comment - - edited daniviga Could you please file a new issue, link it to this one, and label it regression ? Thanks!

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          war/src/main/webapp/scripts/sortable.js
          http://jenkins-ci.org/commit/jenkins/abef5b060f5299ec7790d78db40c18a128dc0b4f
          Log:
          Revert "[FIXED JENKINS-17290] - Corrected sort order of tables"

          This reverts commit d739bedc0d5cc42aa28868fa28a709081460671c.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: war/src/main/webapp/scripts/sortable.js http://jenkins-ci.org/commit/jenkins/abef5b060f5299ec7790d78db40c18a128dc0b4f Log: Revert " [FIXED JENKINS-17290] - Corrected sort order of tables" This reverts commit d739bedc0d5cc42aa28868fa28a709081460671c.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          war/src/main/webapp/scripts/sortable.js
          http://jenkins-ci.org/commit/jenkins/d5651d171b83567d0d6dda899b789ca1de069385
          Log:
          Merge pull request #1737 from oleg-nenashev/master

          [FIXED JENKINS-28601] Revert "[FIXED JENKINS-17290] - Corrected sort order of tables"

          Compare: https://github.com/jenkinsci/jenkins/compare/7e1a92157ddf...d5651d171b83

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: war/src/main/webapp/scripts/sortable.js http://jenkins-ci.org/commit/jenkins/d5651d171b83567d0d6dda899b789ca1de069385 Log: Merge pull request #1737 from oleg-nenashev/master [FIXED JENKINS-28601] Revert " [FIXED JENKINS-17290] - Corrected sort order of tables" Compare: https://github.com/jenkinsci/jenkins/compare/7e1a92157ddf...d5651d171b83

          Daniel Beck added a comment -

          Reverted towards 1.618 because of the regressions this caused.

          Daniel Beck added a comment - Reverted towards 1.618 because of the regressions this caused.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4177
          Revert "[FIXED JENKINS-17290] - Corrected sort order of tables" (Revision abef5b060f5299ec7790d78db40c18a128dc0b4f)

          Result = SUCCESS
          o.v.nenashev : abef5b060f5299ec7790d78db40c18a128dc0b4f
          Files :

          • war/src/main/webapp/scripts/sortable.js

          dogfood added a comment - Integrated in jenkins_main_trunk #4177 Revert " [FIXED JENKINS-17290] - Corrected sort order of tables" (Revision abef5b060f5299ec7790d78db40c18a128dc0b4f) Result = SUCCESS o.v.nenashev : abef5b060f5299ec7790d78db40c18a128dc0b4f Files : war/src/main/webapp/scripts/sortable.js

            Unassigned Unassigned
            marc_guenther Marc Günther
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated: