Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-17858

<f:dropdownDescriptorSelector> does not allow defaulting to specifig instance

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      The <f:dropdownDescriptorSelector> provides a way to define a default descriptor, e.g.:

      <f:dropdownDescriptorSelector title="${%Settings file}" field="settings" default="${descriptor.defaultSettingsProvider.descriptor}"/>

      This allows to define the default descriptor to be used, but does not allow defaulting to a specific instance of this descriptor e.g.:

      <f:dropdownDescriptorSelector title="${%Settings file}" field="settings" default="${descriptor.defaultSettingsProvider}"/>

        Attachments

          Issue Links

            Activity

            Hide
            domi Dominik Bartholdi added a comment -

            the <f:dropdownDescriptorSelector> needs to support defaulting to specific instance to ease the code in JENKINS-17723

            Show
            domi Dominik Bartholdi added a comment - the <f:dropdownDescriptorSelector> needs to support defaulting to specific instance to ease the code in JENKINS-17723
            Hide
            domi Dominik Bartholdi added a comment -
            Show
            domi Dominik Bartholdi added a comment - pull request send: https://github.com/jenkinsci/jenkins/pull/771
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: imod
            Path:
            core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly
            http://jenkins-ci.org/commit/jenkins/961f691cf03b0701787eae3506ba7fa18d06279c
            Log:
            [FIXED JENKINS-17858] allow <f:dropdownDescriptorSelector> to be defaulting to a specifig instance

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly http://jenkins-ci.org/commit/jenkins/961f691cf03b0701787eae3506ba7fa18d06279c Log: [FIXED JENKINS-17858] allow <f:dropdownDescriptorSelector> to be defaulting to a specifig instance
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Olivier Lamy
            Path:
            core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly
            http://jenkins-ci.org/commit/jenkins/1182fe44c08b69eb9a00bd3720467ab0ad5ac739
            Log:
            Merge pull request #771 from imod/dropdownDescriptorSelector-defaulting-to-instance

            [FIXED JENKINS-17858] allow <f:dropdownDescriptorSelector> to be defaulting to an instance

            Compare: https://github.com/jenkinsci/jenkins/compare/4627ec9f99d8...1182fe44c08b

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly http://jenkins-ci.org/commit/jenkins/1182fe44c08b69eb9a00bd3720467ab0ad5ac739 Log: Merge pull request #771 from imod/dropdownDescriptorSelector-defaulting-to-instance [FIXED JENKINS-17858] allow <f:dropdownDescriptorSelector> to be defaulting to an instance Compare: https://github.com/jenkinsci/jenkins/compare/4627ec9f99d8...1182fe44c08b
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Olivier Lamy
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/ac8dab9f74b48af138acb0125b5cdfc04cea0978
            Log:
            Update changelog.html

            changelog entry for JENKINS-17858

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: changelog.html http://jenkins-ci.org/commit/jenkins/ac8dab9f74b48af138acb0125b5cdfc04cea0978 Log: Update changelog.html changelog entry for JENKINS-17858
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2513
            [FIXED JENKINS-17858] allow <f:dropdownDescriptorSelector> to be defaulting to a specifig instance (Revision 961f691cf03b0701787eae3506ba7fa18d06279c)

            Result = SUCCESS
            imod : 961f691cf03b0701787eae3506ba7fa18d06279c
            Files :

            • core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2513 [FIXED JENKINS-17858] allow <f:dropdownDescriptorSelector> to be defaulting to a specifig instance (Revision 961f691cf03b0701787eae3506ba7fa18d06279c) Result = SUCCESS imod : 961f691cf03b0701787eae3506ba7fa18d06279c Files : core/src/main/resources/lib/form/dropdownDescriptorSelector.jelly
            Hide
            jglick Jesse Glick added a comment -

            I do not think this is an lts-candidate; it is an RFE, and AFAICT plugins can work around the lack of it in core by making a private copy of the tag definition.

            Show
            jglick Jesse Glick added a comment - I do not think this is an lts-candidate ; it is an RFE, and AFAICT plugins can work around the lack of it in core by making a private copy of the tag definition.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              domi Dominik Bartholdi
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: