Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18118

User avatar icons broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Jenkins trunk, hpi:run. news for a random user in AsynchPeople returns "avatar":"null/images/32x32/user.png", producing a broken image link. The problem seems to be that since the fix of JENKINS-16342, UserAvatarResolver.resolve is called in a background thread, so Jenkins.rootUrl is null.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Only happens when the Jenkins root URL has not been configured, which you are encouraged to do. Still, Jenkins does not otherwise require this to be set merely to produce links in its own web UI.

            Show
            jglick Jesse Glick added a comment - Only happens when the Jenkins root URL has not been configured, which you are encouraged to do. Still, Jenkins does not otherwise require this to be set merely to produce links in its own web UI.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/View.java
            core/src/main/java/hudson/tasks/UserAvatarResolver.java
            http://jenkins-ci.org/commit/jenkins/8549e7b32debae32827cca4cd6e7aa69858140b0
            Log:
            [FIXED JENKINS-18118] Introduced UserAvatarResolver.resolveOrNull to properly produce fallback icon URL.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java core/src/main/java/hudson/tasks/UserAvatarResolver.java http://jenkins-ci.org/commit/jenkins/8549e7b32debae32827cca4cd6e7aa69858140b0 Log: [FIXED JENKINS-18118] Introduced UserAvatarResolver.resolveOrNull to properly produce fallback icon URL.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2553
            [FIXED JENKINS-18118] Introduced UserAvatarResolver.resolveOrNull to properly produce fallback icon URL. (Revision 8549e7b32debae32827cca4cd6e7aa69858140b0)

            Result = SUCCESS
            Jesse Glick : 8549e7b32debae32827cca4cd6e7aa69858140b0
            Files :

            • changelog.html
            • core/src/main/java/hudson/tasks/UserAvatarResolver.java
            • core/src/main/java/hudson/model/View.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2553 [FIXED JENKINS-18118] Introduced UserAvatarResolver.resolveOrNull to properly produce fallback icon URL. (Revision 8549e7b32debae32827cca4cd6e7aa69858140b0) Result = SUCCESS Jesse Glick : 8549e7b32debae32827cca4cd6e7aa69858140b0 Files : changelog.html core/src/main/java/hudson/tasks/UserAvatarResolver.java core/src/main/java/hudson/model/View.java

              People

              Assignee:
              jglick Jesse Glick
              Reporter:
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: