Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18312

changelog browsing uses the wrong path to Redmine

XMLWordPrintable

      I'm running the latest plugin agains Redmine 2.3.0.
      When browsing the changelog, it leads to "repositories/entry/" + projectName + filePath (https://github.com/jenkinsci/redmine-plugin/blob/master/src/main/java/hudson/plugins/redmine/RedmineRepositoryBrowser.java, line 49)

      However, the format in Redmine is: /redmine/projects/<projectName>/repository/entry/<filePath>

      Same thing with the revision views: In the plugin is "repositories/revision/" + projectName + "/" + changeSet.getRevision()
      but in Redmine is different.

        1. RedmineLinks.patch
          2 kB
        2. RedmineRepositoryBrowser.java
          4 kB

          [JENKINS-18312] changelog browsing uses the wrong path to Redmine

          Jeroen Mostert added a comment - - edited

          I'm running Redmine 2.3.1 ( and latest redmine 0.13 plugin in Jenkins)

          For revision view the format in Redmine 2.3.1 is:
          http://redmineHost/redmine/projects/<projectName>/repository/revisions/<revision>

          Jeroen Mostert added a comment - - edited I'm running Redmine 2.3.1 ( and latest redmine 0.13 plugin in Jenkins) For revision view the format in Redmine 2.3.1 is: http://redmineHost/redmine/projects/ <projectName>/repository/revisions/<revision>

          Jeroen Mostert added a comment -

          Code that should fix it. (original from https://svn.jenkins-ci.org/trunk/hudson/plugins/redmine/src/main/java/hudson/plugins/redmine/RedmineRepositoryBrowser.java) Not sure if this gives a problem with old redmines.

          Jeroen Mostert added a comment - Code that should fix it. (original from https://svn.jenkins-ci.org/trunk/hudson/plugins/redmine/src/main/java/hudson/plugins/redmine/RedmineRepositoryBrowser.java ) Not sure if this gives a problem with old redmines.

          Jeroen Mostert added a comment -

          Hi everyone. I need this bug/feature so much that I'm willing to pay 25.00 bucks for it.
          This offer is registered at FreedomSponsors (http://www.freedomsponsors.org/core/issue/279/changelog-browsing-uses-the-wrong-path).
          Once you solve it (according to the acceptance criteria described there), just create a FreedomSponsors account and mark it as resolved (oh, you'll need a Paypal account too)
          I'll then check it out and will gladly pay up!

          If anyone else would like to throw in a few bucks to elevate the priority on this issue, you should check out FreedomSponsors!

          Jeroen Mostert added a comment - Hi everyone. I need this bug/feature so much that I'm willing to pay 25.00 bucks for it. This offer is registered at FreedomSponsors ( http://www.freedomsponsors.org/core/issue/279/changelog-browsing-uses-the-wrong-path ). Once you solve it (according to the acceptance criteria described there), just create a FreedomSponsors account and mark it as resolved (oh, you'll need a Paypal account too) I'll then check it out and will gladly pay up! If anyone else would like to throw in a few bucks to elevate the priority on this issue, you should check out FreedomSponsors!

          sogabe added a comment -

          Why don't you create pull request ? see https://github.com/jenkinsci/redmine-plugin

          sogabe added a comment - Why don't you create pull request ? see https://github.com/jenkinsci/redmine-plugin

          Łukasz Jąder added a comment - - edited

          Probably this PR https://github.com/jenkinsci/redmine-plugin/pull/10 could fix this issue, but merging it into main repo and releasing it could take some time.

          Łukasz Jąder added a comment - - edited Probably this PR https://github.com/jenkinsci/redmine-plugin/pull/10 could fix this issue, but merging it into main repo and releasing it could take some time.

          Jeroen Mostert added a comment -

          Patch on RedmineRepositoryBrowser.java

          Jeroen Mostert added a comment - Patch on RedmineRepositoryBrowser.java

          cforce added a comment - - edited

          I am looking for a new version availabe in plugin center with merged 3 month work of yoichi's and ljader's, see
          https://github.com/jenkinsci/redmine-plugin/network

          Please release more often and soon!

          cforce added a comment - - edited I am looking for a new version availabe in plugin center with merged 3 month work of yoichi's and ljader's, see https://github.com/jenkinsci/redmine-plugin/network Please release more often and soon!

          sogabe added a comment - - edited

          @gaooh, The maintainer of this plugin will merge pull requests this weekend.

          sogabe added a comment - - edited @gaooh, The maintainer of this plugin will merge pull requests this weekend.

          Łukasz Jąder added a comment -

          FYI I've made commit access request https://groups.google.com/forum/?fromgroups=#!topic/jenkinsci-dev/LEVW1VvJ5OA to be able to address also this issue.
          Please consider

          Łukasz Jąder added a comment - FYI I've made commit access request https://groups.google.com/forum/?fromgroups=#!topic/jenkinsci-dev/LEVW1VvJ5OA to be able to address also this issue. Please consider

          Jeroen Mostert added a comment -

          I compared PR https://github.com/jenkinsci/redmine-plugin/pull/10 with my patch and as far as I can see this should result in the same links to redmine.

          Jeroen Mostert added a comment - I compared PR https://github.com/jenkinsci/redmine-plugin/pull/10 with my patch and as far as I can see this should result in the same links to redmine.

          Yoichi Nakayama added a comment -

          The pull request has been merged, and commits "[maven-release-plugin] prepare release redmine-0.14" came, but 0.14 is unavailable.
          What is happening?

          Yoichi Nakayama added a comment - The pull request has been merged, and commits " [maven-release-plugin] prepare release redmine-0.14" came, but 0.14 is unavailable. What is happening?

          Łukasz Jąder added a comment -

          I've also noticed those release problems so I reported it in https://issues.jenkins-ci.org/browse/JENKINS-18985

          Łukasz Jąder added a comment - I've also noticed those release problems so I reported it in https://issues.jenkins-ci.org/browse/JENKINS-18985

          Łukasz Jąder added a comment -

          Released 0.15 version which should contain fixes for this issue.
          Release is visible in update center after refresh.

          Łukasz Jąder added a comment - Released 0.15 version which should contain fixes for this issue. Release is visible in update center after refresh.

            ljader Łukasz Jąder
            milman uri milman
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: