Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18373

Incorrect redirect after editing view with Unicode name

    XMLWordPrintable

Details

    Description

      I believe as of https://github.com/jenkinsci/jenkins/commit/fbb2bca in 1.500, when using Winstone, if a View has a non-ASCII name, after you Save its configuration you are redirected to a bogus URL which gives a 404.

      Attachments

        Activity

          jglick Jesse Glick created issue -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/View.java
          test/src/test/java/hudson/model/ViewTest.java
          http://jenkins-ci.org/commit/jenkins/80328483465027495c01d20ae11d743a46965c01
          Log:
          [FIXED JENKINS-18373] View.doConfigSubmit must rawEncode its name.

          Compare: https://github.com/jenkinsci/jenkins/compare/1e7b82aea072...803284834650

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java test/src/test/java/hudson/model/ViewTest.java http://jenkins-ci.org/commit/jenkins/80328483465027495c01d20ae11d743a46965c01 Log: [FIXED JENKINS-18373] View.doConfigSubmit must rawEncode its name. Compare: https://github.com/jenkinsci/jenkins/compare/1e7b82aea072...803284834650
          scm_issue_link SCM/JIRA link daemon made changes -
          Field Original Value New Value
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2622
          [FIXED JENKINS-18373] View.doConfigSubmit must rawEncode its name. (Revision 80328483465027495c01d20ae11d743a46965c01)

          Result = SUCCESS
          Jesse Glick : 80328483465027495c01d20ae11d743a46965c01
          Files :

          • test/src/test/java/hudson/model/ViewTest.java
          • changelog.html
          • core/src/main/java/hudson/model/View.java
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2622 [FIXED JENKINS-18373] View.doConfigSubmit must rawEncode its name. (Revision 80328483465027495c01d20ae11d743a46965c01) Result = SUCCESS Jesse Glick : 80328483465027495c01d20ae11d743a46965c01 Files : test/src/test/java/hudson/model/ViewTest.java changelog.html core/src/main/java/hudson/model/View.java
          danielbeck Daniel Beck made changes -
          Labels regression unicode view lts-candidate regression unicode view

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/hudson/model/View.java
          test/src/test/java/hudson/model/ViewTest.java
          http://jenkins-ci.org/commit/jenkins/3a527ecd5c678bdf9f1d9c0b9eb331130672b8dd
          Log:
          [FIXED JENKINS-18373] View.doConfigSubmit must rawEncode its name.
          (cherry picked from commit 80328483465027495c01d20ae11d743a46965c01)

          Conflicts:
          changelog.html
          test/src/test/java/hudson/model/ViewTest.java

          Compare: https://github.com/jenkinsci/jenkins/compare/d7e370236249...3a527ecd5c67

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/View.java test/src/test/java/hudson/model/ViewTest.java http://jenkins-ci.org/commit/jenkins/3a527ecd5c678bdf9f1d9c0b9eb331130672b8dd Log: [FIXED JENKINS-18373] View.doConfigSubmit must rawEncode its name. (cherry picked from commit 80328483465027495c01d20ae11d743a46965c01) Conflicts: changelog.html test/src/test/java/hudson/model/ViewTest.java Compare: https://github.com/jenkinsci/jenkins/compare/d7e370236249...3a527ecd5c67
          olivergondza Oliver Gond┼ża made changes -
          Labels lts-candidate regression unicode view 1.509.4-fixed regression unicode view
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 149680 ] JNJira + In-Review [ 193240 ]

          People

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: