Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18381

Some node properties do not make sense as global node properties

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Since 1.472+ it has been possible to configure the master node's own properties.

      There are some node properties that do not make sense as a global node property. Up until Jenkins 1.472 the way to mark properties as such was to return false from NodePropertyDescriptor.isApplicable(clazz) if clazz instanceof Jenkins

      That technique no longer works as that also means that the property cannot be configured as a node property of the master directly.

      There needs to be an alternative mechanism for differentiating properties that can be applied to all nodes from properties that can be applied to the master node.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          changelog.html
          core/src/main/java/hudson/Functions.java
          core/src/main/java/hudson/slaves/NodePropertyDescriptor.java
          core/src/main/resources/jenkins/model/GlobalNodePropertiesConfiguration/config.groovy
          http://jenkins-ci.org/commit/jenkins/48e801023123f84ee4eebf60737089f41b44958e
          Log:
          JENKINS-18381 Provide a mechanism to differentiate between node
          properties that are applicable to the master node only and node properties
          that can be applied to all nodes

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: changelog.html core/src/main/java/hudson/Functions.java core/src/main/java/hudson/slaves/NodePropertyDescriptor.java core/src/main/resources/jenkins/model/GlobalNodePropertiesConfiguration/config.groovy http://jenkins-ci.org/commit/jenkins/48e801023123f84ee4eebf60737089f41b44958e Log: JENKINS-18381 Provide a mechanism to differentiate between node properties that are applicable to the master node only and node properties that can be applied to all nodes
          Show
          stephenconnolly Stephen Connolly added a comment - Implemented in https://github.com/jenkinsci/jenkins/commit/48e801023123f84ee4eebf60737089f41b44958e
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2626
          JENKINS-18381 Provide a mechanism to differentiate between node (Revision 48e801023123f84ee4eebf60737089f41b44958e)

          Result = UNSTABLE
          Stephen Connolly : 48e801023123f84ee4eebf60737089f41b44958e
          Files :

          • core/src/main/java/hudson/slaves/NodePropertyDescriptor.java
          • core/src/main/java/hudson/Functions.java
          • changelog.html
          • core/src/main/resources/jenkins/model/GlobalNodePropertiesConfiguration/config.groovy
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2626 JENKINS-18381 Provide a mechanism to differentiate between node (Revision 48e801023123f84ee4eebf60737089f41b44958e) Result = UNSTABLE Stephen Connolly : 48e801023123f84ee4eebf60737089f41b44958e Files : core/src/main/java/hudson/slaves/NodePropertyDescriptor.java core/src/main/java/hudson/Functions.java changelog.html core/src/main/resources/jenkins/model/GlobalNodePropertiesConfiguration/config.groovy

            People

            Assignee:
            stephenconnolly Stephen Connolly
            Reporter:
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: