Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18574

changelog use external path for affected path, not workspace related

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • subversion-plugin
    • None

      repository is using svn:externals
      when changed are committer to external, changelog reports affected path based on external repository root, not local workspace

      maven plugin then fails to detect impacted modules to be built (incremental build option)

          [JENKINS-18574] changelog use external path for affected path, not workspace related

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SubversionChangeLogBuilder.java
          src/test/java/hudson/scm/SubversionSCMTest.java
          http://jenkins-ci.org/commit/subversion-plugin/929864e62792091585ac4d4bf7710fd708841c1f
          Log:
          Merge pull request #78 from daniel-beck/JENKINS-22778

          [FIXED JENKINS-22778] Revert JENKINS-18574 related changes

          Compare: https://github.com/jenkinsci/subversion-plugin/compare/a923c5011464...929864e62792

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/test/java/hudson/scm/SubversionSCMTest.java http://jenkins-ci.org/commit/subversion-plugin/929864e62792091585ac4d4bf7710fd708841c1f Log: Merge pull request #78 from daniel-beck/ JENKINS-22778 [FIXED JENKINS-22778] Revert JENKINS-18574 related changes Compare: https://github.com/jenkinsci/subversion-plugin/compare/a923c5011464...929864e62792

          kutzi added a comment -

          Original fix caused: JENKINS-22199

          kutzi added a comment - Original fix caused: JENKINS-22199

          kutzi added a comment -

          Changes from the original fix have been backed out altother as it caused regressions JENKINS-22199 and JENKINS-22778

          See: https://github.com/jenkinsci/subversion-plugin/commit/929864e62792091585ac4d4bf7710fd708841c1f

          kutzi added a comment - Changes from the original fix have been backed out altother as it caused regressions JENKINS-22199 and JENKINS-22778 See: https://github.com/jenkinsci/subversion-plugin/commit/929864e62792091585ac4d4bf7710fd708841c1f

          Daniel Beck added a comment -

          Possible solution for this issue: https://github.com/jenkinsci/subversion-plugin/pull/80

          I'd like to get some feedback whether this actually works, so please check it out.

          Daniel Beck added a comment - Possible solution for this issue: https://github.com/jenkinsci/subversion-plugin/pull/80 I'd like to get some feedback whether this actually works, so please check it out.

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SubversionChangeLogBuilder.java
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          http://jenkins-ci.org/commit/subversion-plugin/3626e900eec41fa777de23d5ea09355ca4e92718
          Log:
          [FIXED JENKINS-18574]

          AffectedFile contract specifies "path in the workspace that was affected".

          Until now, Subversion plugin returned the full path relative to repo
          root instead.

          This commit adds storing the relative path to a file in the workspace
          to the changelog.xml, and returns that path for AffectedFile.getPath().

          Existing Subversion-specific consumers need to switch to getValue()
          if they're not using it already, which continues to return the full
          path within the repository (e.g. repository browsers).

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionChangeLogSet.java http://jenkins-ci.org/commit/subversion-plugin/3626e900eec41fa777de23d5ea09355ca4e92718 Log: [FIXED JENKINS-18574] AffectedFile contract specifies "path in the workspace that was affected". Until now, Subversion plugin returned the full path relative to repo root instead. This commit adds storing the relative path to a file in the workspace to the changelog.xml, and returns that path for AffectedFile.getPath(). Existing Subversion-specific consumers need to switch to getValue() if they're not using it already, which continues to return the full path within the repository (e.g. repository browsers).

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/test/java/hudson/scm/SubversionChangeLogParserTest.java
          src/test/resources/hudson/scm/changelog_relativepath.xml
          http://jenkins-ci.org/commit/subversion-plugin/8a1e46fcaa6a93efb3acefc28454e8163074ef02
          Log:
          JENKINS-18574 Add log parsing test

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/test/java/hudson/scm/SubversionChangeLogParserTest.java src/test/resources/hudson/scm/changelog_relativepath.xml http://jenkins-ci.org/commit/subversion-plugin/8a1e46fcaa6a93efb3acefc28454e8163074ef02 Log: JENKINS-18574 Add log parsing test

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SubversionChangeLogBuilder.java
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          src/test/java/hudson/scm/SubversionChangeLogParserTest.java
          src/test/resources/hudson/scm/changelog_relativepath.xml
          http://jenkins-ci.org/commit/subversion-plugin/5a2683ed4a7d8b384577188cb4733345afb14d71
          Log:
          Merge pull request #80 from daniel-beck/JENKINS-18574

          [RFC] FIX JENKINS-18574/JENKINS-16045

          Compare: https://github.com/jenkinsci/subversion-plugin/compare/6e4e39127eb7...5a2683ed4a7d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogBuilder.java src/main/java/hudson/scm/SubversionChangeLogSet.java src/test/java/hudson/scm/SubversionChangeLogParserTest.java src/test/resources/hudson/scm/changelog_relativepath.xml http://jenkins-ci.org/commit/subversion-plugin/5a2683ed4a7d8b384577188cb4733345afb14d71 Log: Merge pull request #80 from daniel-beck/ JENKINS-18574 [RFC] FIX JENKINS-18574 / JENKINS-16045 Compare: https://github.com/jenkinsci/subversion-plugin/compare/6e4e39127eb7...5a2683ed4a7d

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly
          http://jenkins-ci.org/commit/subversion-plugin/08ed6c99c7d762b32243bf3121f08b4229e98c8b
          Log:
          JENKINS-18574 Fixes for multiple locations in same repo

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogSet.java src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly http://jenkins-ci.org/commit/subversion-plugin/08ed6c99c7d762b32243bf3121f08b4229e98c8b Log: JENKINS-18574 Fixes for multiple locations in same repo

          Code changed in jenkins
          User: Nicolas De loof
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly
          http://jenkins-ci.org/commit/subversion-plugin/91b92a5bb89cd59cae4e2a3ef86ab7102c9af016
          Log:
          Merge pull request #85 from daniel-beck/JENKINS-18574-2

          JENKINS-18574 Fixes for multiple locations in same repo

          Compare: https://github.com/jenkinsci/subversion-plugin/compare/396837b69f1e...91b92a5bb89c

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogSet.java src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly http://jenkins-ci.org/commit/subversion-plugin/91b92a5bb89cd59cae4e2a3ef86ab7102c9af016 Log: Merge pull request #85 from daniel-beck/ JENKINS-18574 -2 JENKINS-18574 Fixes for multiple locations in same repo Compare: https://github.com/jenkinsci/subversion-plugin/compare/396837b69f1e...91b92a5bb89c

          Code changed in jenkins
          User: Daniel Beck
          Path:
          src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java
          src/main/java/hudson/scm/SubversionChangeLogSet.java
          src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly
          http://jenkins-ci.org/commit/subversion-plugin/7979b652011cd661f0c0fffec4c4b173838c5784
          Log:
          JENKINS-18574 Fixes for multiple locations in same repo

          (cherry picked from commit 08ed6c99c7d762b32243bf3121f08b4229e98c8b)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/hudson/scm/DirAwareSVNXMLLogHandler.java src/main/java/hudson/scm/SubversionChangeLogSet.java src/main/resources/hudson/scm/SubversionChangeLogSet/index.jelly http://jenkins-ci.org/commit/subversion-plugin/7979b652011cd661f0c0fffec4c4b173838c5784 Log: JENKINS-18574 Fixes for multiple locations in same repo (cherry picked from commit 08ed6c99c7d762b32243bf3121f08b4229e98c8b)

            Unassigned Unassigned
            ndeloof Nicolas De Loof
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: