Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18585

Error: TypeError: e.up(...).on is not a function on job-configuration screen, which never finishes loading/has broken Save button

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      We upgraded just this morning to version 1.521, and when going into the job-configuration page, the following two things happen:

      1) the "Save" button isn't correctly styled (it's small) and throws an error on click
      2) we see the Configuration-Loading overlay, and see this in the Error Console:

      Timestamp: 7/2/2013 12:52:16 PM
      Error: TypeError: e.up(...).on is not a function
      Source File: http://qa-selenium-stage.mv.mozilla.com:8080/adjuncts/562581b0/lib/form/textarea/textarea.js
      Line: 18

          [JENKINS-18585] Error: TypeError: e.up(...).on is not a function on job-configuration screen, which never finishes loading/has broken Save button

          Stephen Donner created issue -
          Stephen Donner made changes -
          Attachment New: error-loading.png [ 23823 ]

          sogabe added a comment -

          sogabe added a comment - already fixed. see https://github.com/jenkinsci/jenkins/commit/0256f0a74e9b3373fa9fa14ba32bf9cb99dd5ec3

          James Howe added a comment -

          Is there no testing done at all before a build is released?

          James Howe added a comment - Is there no testing done at all before a build is released?

          kutzi added a comment -

          Already fixed according to sogabe

          kutzi added a comment - Already fixed according to sogabe
          kutzi made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          sogabe made changes -
          Link New: This issue is duplicated by JENKINS-18595 [ JENKINS-18595 ]

          Actually, the problem is not visible with a pure jenkins core, however it happens if you have plugins like EnvInject installed.

          Vincent Latombe added a comment - Actually, the problem is not visible with a pure jenkins core, however it happens if you have plugins like EnvInject installed.

          Quick and dirty fix before 1.522 release:
          1. Extract textarea.js from jenkins.war/WEB-INF/lib/jenkins-core-1.521.jar/lib/form/textarea/
          2. Modify line 18 as in https://github.com/jenkinsci/jenkins/commit/0256f0a74e9b3373fa9fa14ba32bf9cb99dd5ec3
          3. Place modified file textarea.js into war/WEB-INF/classes/lib/form/textarea/
          4. Restart jenkins service (optionally clearing browser cache for jenkins).

          Disclaimer: I'm not sure how this modified file will be handled on jenkins update.

          Łukasz Jąder added a comment - Quick and dirty fix before 1.522 release: 1. Extract textarea.js from jenkins.war/WEB-INF/lib/jenkins-core-1.521.jar/lib/form/textarea/ 2. Modify line 18 as in https://github.com/jenkinsci/jenkins/commit/0256f0a74e9b3373fa9fa14ba32bf9cb99dd5ec3 3. Place modified file textarea.js into war/WEB-INF/classes/lib/form/textarea/ 4. Restart jenkins service (optionally clearing browser cache for jenkins). Disclaimer: I'm not sure how this modified file will be handled on jenkins update.

          It would be nice to have a corresponding entry in the changelog as well.

          Björn Pedersen added a comment - It would be nice to have a corresponding entry in the changelog as well.

            Unassigned Unassigned
            stephendonner Stephen Donner
            Votes:
            0 Vote for this issue
            Watchers:
            12 Start watching this issue

              Created:
              Updated:
              Resolved: