Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18723

Relative links to job are built very slowly

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core

      If a View contains 10 jobs, while building relative links Jenkins would build this view 10 times iterating over all Jenkins jobs. This is an extremely inefficient way of building links.

      Details:

      • projectView.jelly#L84 this one asks Functions to build a relative link.
      • Functions.java#L1008 it obtains all items of the view which builds it and accesses Security to iterate through all the jobs in Jenkins. Note, that this code was added 2 months ago.

      Either there should be a different way of building relative path or a different way for building view items.

          [JENKINS-18723] Relative links to job are built very slowly

          Stanislav Bashkyrtsev created issue -
          Stanislav Bashkyrtsev made changes -
          Labels New: performance
          Stanislav Bashkyrtsev made changes -
          Priority Original: Major [ 3 ] New: Critical [ 2 ]
          Joe Zeldin made changes -
          Link New: This issue is related to JENKINS-18377 [ JENKINS-18377 ]
          Stanislav Bashkyrtsev made changes -
          Description Original: If a View contains 10 jobs, while building relative links Jenkins would build this view 10 times iterating over all Jenkins jobs. This is an *extremely* inefficient way of building links.

          *Details*:
          * [projectView.jelly#L84|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/hudson/projectView.jelly#L84] this one asks Functions to build a relative link.
          * [Functions.java#L951|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/Functions.java#L951] it obtains all items of the view which builds it and accesses Security to iterate through all(!) the jobs in Jenkins. Note, that this code was added 2 months ago.

          Either there should be a different way of building relative path or a different way for building view items.           		New: If a View contains 10 jobs, while building relative links Jenkins would build this view 10 times iterating over all Jenkins jobs. This is an *extremely* inefficient way of building links.

          *Details*:
          * [projectView.jelly#L84|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/lib/hudson/projectView.jelly#L84] this one asks Functions to build a relative link.
          * [Functions.java#L1008|https://github.com/jenkinsci/jenkins/blob/7232798611b66f4a03ad8670c07cb58220f4d866/core/src/main/java/hudson/Functions.java#L1008] it obtains all items of the view which builds it and accesses Security to iterate through all(!) the jobs in Jenkins. Note, that this code was added 2 months ago.

          Either there should be a different way of building relative path or a different way for building view items.
          Stanislav Bashkyrtsev made changes -
          Link New: This issue is related to JENKINS-17715 [ JENKINS-17715 ]

          Stanislav Bashkyrtsev added a comment -

          Pull request was sent with the fix: https://github.com/jenkinsci/jenkins/pull/925

          Stanislav Bashkyrtsev added a comment - Pull request was sent with the fix: https://github.com/jenkinsci/jenkins/pull/925

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: ctapobep
          Path:
          core/src/main/resources/lib/hudson/projectView.jelly
          http://jenkins-ci.org/commit/jenkins/cc259504ae050e705a55613fbc78e38f81b18496
          Log:
          JENKINS-18723 Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: ctapobep Path: core/src/main/resources/lib/hudson/projectView.jelly http://jenkins-ci.org/commit/jenkins/cc259504ae050e705a55613fbc78e38f81b18496 Log: JENKINS-18723 Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/resources/lib/hudson/projectView.jelly
          http://jenkins-ci.org/commit/jenkins/c63e1f7084abc5c1e440d7a1785f2a2d5a035b78
          Log:
          Merge pull request #925 from ctapobep/master

          JENKINS-18723 Fixed performance bottleneck. Corrected the formation of...

          Compare: https://github.com/jenkinsci/jenkins/compare/574fe1409ec8...c63e1f7084ab

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/lib/hudson/projectView.jelly http://jenkins-ci.org/commit/jenkins/c63e1f7084abc5c1e440d7a1785f2a2d5a035b78 Log: Merge pull request #925 from ctapobep/master JENKINS-18723 Fixed performance bottleneck. Corrected the formation of... Compare: https://github.com/jenkinsci/jenkins/compare/574fe1409ec8...c63e1f7084ab

          Jesse Glick added a comment -

          Still open, #925 halved the time required but it is still too long.

          Jesse Glick added a comment - Still open, #925 halved the time required but it is still too long.

            Unassigned Unassigned
            ctapobep Stanislav Bashkyrtsev
            Votes:
            6 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: