a stapler change in 1.208 broke the @InjectedParameter annotation handling.

      When non-injected annotation (such as @RelativePath) annotation is present, it'll mask the handling of the injected annotation (such as @QueryParameter.)

          [JENKINS-18776] @QueryParameter with @RelativePath broken

          Kohsuke Kawaguchi created issue -
          Kohsuke Kawaguchi made changes -
          Labels New: lts-candidate
          Jesse Glick made changes -
          Labels Original: lts-candidate New: lts-candidate regression

          Jesse Glick added a comment -

          Should be easy enough to write a regression test for this, right?

          Jesse Glick added a comment - Should be easy enough to write a regression test for this, right?

          Hmm, it looks like the SCM/issue link daemon has stopped working.

          This fix is integrated toward 1.525.

          Kohsuke Kawaguchi added a comment - Hmm, it looks like the SCM/issue link daemon has stopped working. This fix is integrated toward 1.525.
          Kohsuke Kawaguchi made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          I'm sorry but what needs to be backported to get this lts-candidate fixed?

          Oliver Gondža added a comment - I'm sorry but what needs to be backported to get this lts-candidate fixed?

          Jesse Glick added a comment -

          I just looked in https://github.com/jenkinsci/jenkins/compare/jenkins-1.524...jenkins-1.525 to try to figure out where the purported fix was, but there are no changes here except version number! Did the release process go haywire?

          Jesse Glick added a comment - I just looked in https://github.com/jenkinsci/jenkins/compare/jenkins-1.524...jenkins-1.525 to try to figure out where the purported fix was, but there are no changes here except version number! Did the release process go haywire?

          Jesse Glick added a comment -

          Anyway https://github.com/stapler/stapler/commit/fb1fa99985058151732a73c1a071383dbd20e116 is the fix, in Stapler 1.214. That was integrated in https://github.com/jenkinsci/jenkins/commit/fc836c135e2bba4fa66239ef42e8b542298cdbd9 and apparently required several follow-up test fixes in https://github.com/jenkinsci/jenkins/compare/efc0ca16fb975229afba1917b03eee160ce68986...504dadca61353bbbf393d4353200330455930e88 (I am guessing). Seems this is really in 1.526, since 1.525 was just botched.

          Jesse Glick added a comment - Anyway https://github.com/stapler/stapler/commit/fb1fa99985058151732a73c1a071383dbd20e116 is the fix, in Stapler 1.214. That was integrated in https://github.com/jenkinsci/jenkins/commit/fc836c135e2bba4fa66239ef42e8b542298cdbd9 and apparently required several follow-up test fixes in https://github.com/jenkinsci/jenkins/compare/efc0ca16fb975229afba1917b03eee160ce68986...504dadca61353bbbf393d4353200330455930e88 (I am guessing). Seems this is really in 1.526, since 1.525 was just botched.

          Thanks Jesse. It seems to require https://github.com/jenkinsci/jenkins/commit/bbaeade5231ca4116047fbd32b2f909a16a59b8d as well for tests to succeed.

          Oliver Gondža added a comment - Thanks Jesse. It seems to require https://github.com/jenkinsci/jenkins/commit/bbaeade5231ca4116047fbd32b2f909a16a59b8d as well for tests to succeed.

            kohsuke Kohsuke Kawaguchi
            kohsuke Kohsuke Kawaguchi
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: