Details
-
Bug
-
Status: Resolved (View Workflow)
-
Critical
-
Resolution: Fixed
-
Jenkins LTS 1.480.3 (affects all versions), both Linux and Windows masters
Description
Reproduction steps:
- Create build with file parameter
- Add execution delay or invalid label restrictions
- Try to put more than one build into queue
Queue build comparator successfully enters FileParameterValue::equals().
According to function docs, "In practice this will always be false, since location should be unique". However, in practice of queued builds location is relative path to file in workspace (which is specified in parameter configs), so that function returns true => Jenkins merges builds even if theirs file parameters are different.
It is not possible to use anything instead of bit-wise file comparison, because different files can be uploaded from same place during manual build submission. It can require much time in long queues...
I propose to consider files as different if they are specified in the build parameters.
Attachments
Issue Links
- is duplicated by
-
-
- Resolved
-
- is related to
-
JENKINS-25211 Compare file fingerprinets/checksums in FileParameterValue
-
- Open
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
Reproduction steps: - Create build with file parameter - Add execution delay or invalid label restrictions - Try to put more than one build into queue Queue build comparator successfully enters FileParameterValue::equals(). According to function docs, "In practice this will always be false, since location should be unique". However, in practice of queued builds location is relative path to file in workspace (which is specified in parameter configs), so that function returns true => Jenkins merges builds even if theirs file parameters are different. It is not possible to use anything instead of bit-wise file comparison, because different files can be uploaded from same place during manual build submission. It can require much time in long queues... I propose to treat consider files as different if they are specified in the build parameters. |
Reproduction steps: - Create build with file parameter - Add execution delay or invalid label restrictions - Try to put more than one build into queue Queue build comparator successfully enters FileParameterValue::equals(). According to function docs, "In practice this will always be false, since location should be unique". However, in practice of queued builds location is relative path to file in workspace (which is specified in parameter configs), so that function returns true => Jenkins merges builds even if theirs file parameters are different. It is not possible to use anything instead of bit-wise file comparison, because different files can be uploaded from same place during manual build submission. It can require much time in long queues... I propose to consider files as different if they are specified in the build parameters. |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Labels | lts-candidate |
| Link |
This issue is duplicated by |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Link | This issue is related to JENKINS-25211 [ JENKINS-25211 ] |
| Labels | lts-candidate | 1.580.2-fixed |
| Workflow | JNJira [ 150464 ] | JNJira + In-Review [ 193530 ] |