-
Bug
-
Resolution: Unresolved
-
Critical
-
None
It looks like ghprb blocks the startup of Jenkins while it tries to contact GitHub. This Jenkins instance should only take a couple of minutes to start, but has taken at least a half hour. Repeated stack traces reveal several jobs stuck as so:
- is related to
-
-
- In Review
-
[JENKINS-19103] ghprb slows Jenkins startup to a crawl
Honza Brázdil
added a comment - The github-api library is waiting because the number of request to GitHub API is limited to 5000 requests per hour for authenticated requests (and 60 for unauthenticated). But I didn't know it could slow down Jenkins start up.
Honza Brázdil
added a comment - The github-api library is waiting because the number of request to GitHub API is limited to 5000 requests per hour for authenticated requests (and 60 for unauthenticated). But I didn't know it could slow down Jenkins start up. 
Ryan Campbell
added a comment - Did you take a look at the stack trace I attached above? I think it clearly demonstrates why this is blocking Jenkins from starting up.
Perhaps the fix is to build the GhprbTrigger.m1 instance in run() instead of start()
Ryan Campbell
added a comment - Did you take a look at the stack trace I attached above? I think it clearly demonstrates why this is blocking Jenkins from starting up.
Perhaps the fix is to build the GhprbTrigger.m1 instance in run() instead of start() Ryan Campbell
added a comment - Actually, my suggestion will just result in the cron thread being blocked, as seen in JENKINS-19123.
Ryan Campbell
added a comment - Actually, my suggestion will just result in the cron thread being blocked, as seen in JENKINS-19123 . 
ryangardner
added a comment - Our jenkins instance takes a very long time to restart and while it is restarting it does log one by one information about the ghprb at startup.
I'm not sure if the ghprb is the bottleneck or just the part of the process that actually logs stuff - but our startups take around 10 minutes to get the UI back in jenkins.
(Jenkins itself will start running builds while the ui still says "Please wait while Jenkins is getting ready to work", but it takes a long time to get jenkins to fully come up)
ryangardner
added a comment - Our jenkins instance takes a very long time to restart and while it is restarting it does log one by one information about the ghprb at startup.
I'm not sure if the ghprb is the bottleneck or just the part of the process that actually logs stuff - but our startups take around 10 minutes to get the UI back in jenkins.
(Jenkins itself will start running builds while the ui still says "Please wait while Jenkins is getting ready to work", but it takes a long time to get jenkins to fully come up) 
Pavel Janoušek
added a comment - This issue might be fixed by proposed fix for JENKINS-19123. GitHub API uses WAIT policy (indefinitely) by default, but can be orchestrated to use FAIL -> fast fail in that case occurs.
Pavel Janoušek
added a comment - This issue might be fixed by proposed fix for JENKINS-19123 . GitHub API uses WAIT policy (indefinitely) by default, but can be orchestrated to use FAIL -> fast fail in that case occurs. 
Raising to critical since this essentially makes Jenkins unavailable for long periods.