Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19457

Buggy plugin implementations break job configuration too easily

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • core
    • None

    Description

      The implementation of registerValidator() in hudson-behavior.js blindly pushes content from the Job configuration (attribute=checkUrl) into an eval() if the attribute "checkDependsOn" is absent.

      In cases where a plugin has no JavaScript in "checkUrl" but a plain URL String the eval() call fails as the content is interpreted as RegEx with invalid flags.

      Here is the current code in Question at line 414 to 424:

      var url = this.getAttribute("checkUrl");
var depends = this.getAttribute("checkDependsOn");

if (depends==null) {// legacy behaviour where checkUrl is a JavaScript
    return eval(url); // need access to 'this', so no 'geval'
} else {
//...

      A simple fix to prevent the breakdown of the overall Job Configuration could be achieved as follows:

      var url = this.getAttribute("checkUrl");
var depends = this.getAttribute("checkDependsOn");

if (depends==null) {// legacy behaviour where checkUrl is a JavaScript
  try {
    return eval(url); // need access to 'this', so no 'geval'
  } catch(e) {
    return url; // if the URL is not JavaScript, simply return the URL
  }
} else {
//...

      This fix or a similar approach would make the UI more robust and less fragile, especially as the core application relies on external (plugin) code.

      Attachments

        Issue Links

          duplicates

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-6542 "LOADING" overlay

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved
          is blocking

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-11074 LOADING Overlay does not go away - IE 8

          • Major - Major loss of function.
          • Resolved
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19248 regression: Upgrading to 1.528 ("Upgrade Automatically") breaks "configure"

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19421 Jenkins 1.529 upgrade breaks the ability to edit existing jenkins jobs / Creating new jenkins jobs

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19366 Configure tab freezes for projects

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Activity

            People

              Unassigned Unassigned
              jabbrwcky Jens Hausherr
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: