Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19910

Support rebuilding projects using maven metadata plugin

        [JENKINS-19910] Support rebuilding projects using maven metadata plugin

        I have created a github pull request for this issue: https://github.com/jenkinsci/rebuild-plugin/pull/16

        Mads Mohr Christensen added a comment - I have created a github pull request for this issue: https://github.com/jenkinsci/rebuild-plugin/pull/16

        Code changed in jenkins
        User: Mads Mohr Christensen
        Path:
        src/main/resources/com/sonyericsson/rebuild/RebuildAction/MavenMetadataParameterValue.jelly
        http://jenkins-ci.org/commit/rebuild-plugin/c5d9b5003b67987019b29bde6f4db7db5e9e4c3f
        Log:
        JENKINS-19910 added support for maven metadata plugin

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mads Mohr Christensen Path: src/main/resources/com/sonyericsson/rebuild/RebuildAction/MavenMetadataParameterValue.jelly http://jenkins-ci.org/commit/rebuild-plugin/c5d9b5003b67987019b29bde6f4db7db5e9e4c3f Log: JENKINS-19910 added support for maven metadata plugin

        Code changed in jenkins
        User: Mads Mohr Christensen
        Path:
        src/main/resources/com/sonyericsson/rebuild/RebuildAction/MavenMetadataParameterValue.jelly
        http://jenkins-ci.org/commit/rebuild-plugin/0b5ba297d64747f7748ea45f354f6b9572c9665e
        Log:
        JENKINS-19910 added support for maven metadata plugin

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mads Mohr Christensen Path: src/main/resources/com/sonyericsson/rebuild/RebuildAction/MavenMetadataParameterValue.jelly http://jenkins-ci.org/commit/rebuild-plugin/0b5ba297d64747f7748ea45f354f6b9572c9665e Log: JENKINS-19910 added support for maven metadata plugin

        Code changed in jenkins
        User: shemeersulaiman
        Path:
        src/main/resources/com/sonyericsson/rebuild/RebuildAction/MavenMetadataParameterValue.jelly
        http://jenkins-ci.org/commit/rebuild-plugin/8b190f7ec7d250290ef4c462092c8e8fb873f76e
        Log:
        Merge pull request #16 from hrmohr/JENKINS-19910

        JENKINS-19910 added support for maven metadata plugin

        Compare: https://github.com/jenkinsci/rebuild-plugin/compare/6812c0e20467...8b190f7ec7d2

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: shemeersulaiman Path: src/main/resources/com/sonyericsson/rebuild/RebuildAction/MavenMetadataParameterValue.jelly http://jenkins-ci.org/commit/rebuild-plugin/8b190f7ec7d250290ef4c462092c8e8fb873f76e Log: Merge pull request #16 from hrmohr/ JENKINS-19910 JENKINS-19910 added support for maven metadata plugin Compare: https://github.com/jenkinsci/rebuild-plugin/compare/6812c0e20467...8b190f7ec7d2

        Included in version 1.21

        Mads Mohr Christensen added a comment - Included in version 1.21

        Using rebuild for a moment it worked fine until I add parameters from maven-metadata_plugin.
        Might be specific to that plugin

        Parameter everest_version_CLASSIFIER was "blank" in the first build.
        The build ran fine
        I wanted to relaunch with the same parameter using rebuild
        The new build failed with this stacktrace

        FATAL: Null value not allowed as an environment variable: everest_version_CLASSIFIER
        java.lang.IllegalArgumentException: Null value not allowed as an environment variable: everest_version_CLASSIFIER
        	at hudson.EnvVars.put(EnvVars.java:356)
        	at eu.markov.jenkins.plugin.mvnmeta.MavenMetadataParameterValue.buildEnvVars(MavenMetadataParameterValue.java:80)
        	at hudson.model.ParameterValue.buildEnvironment(ParameterValue.java:174)
        	at hudson.model.ParametersAction.buildEnvVars(ParametersAction.java:89)
        	at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:950)
        	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1046)
        	at hudson.scm.SCM.checkout(SCM.java:485)
        	at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
        	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
        	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
        	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
        	at hudson.model.Run.execute(Run.java:1738)
        	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
        	at hudson.model.ResourceController.execute(ResourceController.java:98)
        	at hudson.model.Executor.run(Executor.java:410)
        

        versions :

        component version
        jenkins 1.642.2
        maven-metadata_plugin 1.4.1
        rebuild-plugin 1.25

        Sylvain Mougenot added a comment - Using rebuild for a moment it worked fine until I add parameters from maven-metadata_plugin. Might be specific to that plugin Parameter everest_version_CLASSIFIER was "blank" in the first build. The build ran fine I wanted to relaunch with the same parameter using rebuild The new build failed with this stacktrace FATAL: Null value not allowed as an environment variable: everest_version_CLASSIFIER java.lang.IllegalArgumentException: Null value not allowed as an environment variable: everest_version_CLASSIFIER at hudson.EnvVars.put(EnvVars.java:356) at eu.markov.jenkins.plugin.mvnmeta.MavenMetadataParameterValue.buildEnvVars(MavenMetadataParameterValue.java:80) at hudson.model.ParameterValue.buildEnvironment(ParameterValue.java:174) at hudson.model.ParametersAction.buildEnvVars(ParametersAction.java:89) at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:950) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1046) at hudson.scm.SCM.checkout(SCM.java:485) at hudson.model.AbstractProject.checkout(AbstractProject.java:1276) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529) at hudson.model.Run.execute(Run.java:1738) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:410) versions : component version jenkins 1.642.2 maven-metadata_plugin 1.4.1 rebuild-plugin 1.25

        It looks like the Maven Metadata Plugin is being maintained again and therefor it would be better to add support for rebuilding directly in that plugin instead of maintaining support in this plugin.

        I have created a PR for that: https://github.com/jenkinsci/maven-metadata-plugin/pull/12

        Mads Mohr Christensen added a comment - It looks like the Maven Metadata Plugin is being maintained again and therefor it would be better to add support for rebuilding directly in that plugin instead of maintaining support in this plugin. I have created a PR for that: https://github.com/jenkinsci/maven-metadata-plugin/pull/12

        Nice of you to have done the PR
        I hope it will be merged soon
        Thank you

        Sylvain Mougenot added a comment - Nice of you to have done the PR I hope it will be merged soon Thank you

        Code changed in jenkins
        User: Marc Rohlfs
        Path:
        pom.xml
        src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataRebuildParameterProvider.java
        src/main/resources/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue/value.jelly
        http://jenkins-ci.org/commit/maven-metadata-plugin/7cda4a67b0636509536d26a38b41fb895f4e3e10
        Log:
        Merge pull request #12 from hrmohr/JENKINS-19910

        Added support for rebuilding

        Compare: https://github.com/jenkinsci/maven-metadata-plugin/compare/71ee75c47fae...7cda4a67b063

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marc Rohlfs Path: pom.xml src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataRebuildParameterProvider.java src/main/resources/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue/value.jelly http://jenkins-ci.org/commit/maven-metadata-plugin/7cda4a67b0636509536d26a38b41fb895f4e3e10 Log: Merge pull request #12 from hrmohr/ JENKINS-19910 Added support for rebuilding Compare: https://github.com/jenkinsci/maven-metadata-plugin/compare/71ee75c47fae...7cda4a67b063

        Marc Rohlfs added a comment -

        Merged and released with maven-metadata-plugin-1.5.0.

        Marc Rohlfs added a comment - Merged and released with maven-metadata-plugin-1.5.0 .

          mmchr Mads Mohr Christensen
          mmchr Mads Mohr Christensen
          Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

            Created:
            Updated:
            Resolved: