Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20262

Fix for JENKINS-18629 caused a regression in several plugins

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • core

      https://github.com/jenkinsci/jenkins/commit/c01333c346176c93e8cbf93b5822978d8d2c0bff introduced a new behavior that breaks several plugins. The issue seems to arise only when a class that extends Descriptor implements its own newInstance method.

          [JENKINS-20262] Fix for JENKINS-18629 caused a regression in several plugins

          Jesse Glick added a comment -

          I think there is still outstanding work. @kohsuke proposed that we

          deprecate Descriptor.newInstance(StaplerRequest,JSONObject) method, then define an interface in Stapler that allows an object to nominate its own replacement

          and

          [introduce] the inline attribute to the radioBlock tag

          and I proposed that we

          [close] JENKINS-18629 as “will not fix”

          Jesse Glick added a comment - I think there is still outstanding work. @kohsuke proposed that we deprecate Descriptor.newInstance(StaplerRequest,JSONObject) method, then define an interface in Stapler that allows an object to nominate its own replacement and [introduce] the inline attribute to the radioBlock tag and I proposed that we [close] JENKINS-18629 as “will not fix”

          Daniel Beck added a comment -

          Kohsuke, Jesse: Any news here?

          Daniel Beck added a comment - Kohsuke, Jesse: Any news here?

          Alex Earl added a comment -

          Bump, what's the status on this?

          Alex Earl added a comment - Bump, what's the status on this?

          kutzi added a comment - - edited

          Bump bump. This is still listed as a 'Blocker' in the issues of the email-ext plugin. So if one would read the priority as it's meant to be, it would mean that the plugin would be barely usable, if at all.
          Is this correct? If not could we have the priority adjusted - or at least a understandable description (for users not developers) what the actual regression is?

          kutzi added a comment - - edited Bump bump. This is still listed as a 'Blocker' in the issues of the email-ext plugin. So if one would read the priority as it's meant to be, it would mean that the plugin would be barely usable, if at all. Is this correct? If not could we have the priority adjusted - or at least a understandable description (for users not developers) what the actual regression is?

          Alex Earl added a comment -

          Where does it show as a blocker for email-ext?

          Alex Earl added a comment - Where does it show as a blocker for email-ext?

          kutzi added a comment -

          Currently still here: https://wiki.jenkins-ci.org/display/JENKINS/Email-ext+plugin
          But Jesse has now removed the email-ext component from this issue, so it will eventually disappear from the Wiki page, too.

          kutzi added a comment - Currently still here: https://wiki.jenkins-ci.org/display/JENKINS/Email-ext+plugin But Jesse has now removed the email-ext component from this issue, so it will eventually disappear from the Wiki page, too.

          Alex Earl added a comment -

          Just click the "refresh" button on the JIRA widget and it goes away.

          Alex Earl added a comment - Just click the "refresh" button on the JIRA widget and it goes away.

          Any news on this? Believe this is related to ruby-runtime defect ( https://github.com/jenkinsci/jenkins.rb/issues/112 ). If the recommendation is not to use newInstance() then what should the ruby-runtime lib be updated to use? Many ruby-runtime dependent plugins are broken with the build unable to save any post build actions.

          Nicole Jacobson added a comment - Any news on this? Believe this is related to ruby-runtime defect ( https://github.com/jenkinsci/jenkins.rb/issues/112 ). If the recommendation is not to use newInstance() then what should the ruby-runtime lib be updated to use? Many ruby-runtime dependent plugins are broken with the build unable to save any post build actions.

          Daniel Beck added a comment -

          define an interface in Stapler that allows an object to nominate its own replacement

          jglick Is https://github.com/stapler/stapler/blob/master/core/src/main/java/org/kohsuke/stapler/DataBoundResolvable.java what you meant here?

          Daniel Beck added a comment - define an interface in Stapler that allows an object to nominate its own replacement jglick Is https://github.com/stapler/stapler/blob/master/core/src/main/java/org/kohsuke/stapler/DataBoundResolvable.java what you meant here?

          Jesse Glick added a comment -

          danielbeck it was actually kohsuke who wrote that. From looking at DataBoundResolvable, it does sound like the same thing.

          Jesse Glick added a comment - danielbeck it was actually kohsuke who wrote that. From looking at DataBoundResolvable , it does sound like the same thing.

            Unassigned Unassigned
            slide_o_mix Alex Earl
            Votes:
            5 Vote for this issue
            Watchers:
            16 Start watching this issue

              Created:
              Updated: