Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20272

Disconnected nodes don't need to be checked for reponse time

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • 1.536 on OS X

      From the Jenkins log of a non-productive instance I set up to test something:

      Okt 25, 2013 11:26:43 AM hudson.WebAppMain$3 run
      INFO: Jenkins is fully up and running
      Okt 25, 2013 3:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 4:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 5:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 6:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 7:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      Okt 25, 2013 8:26:36 PM hudson.node_monitors.ResponseTimeMonitor$1 monitor
      WARNING: Making ffoooo offline because it’s not responding
      

      The node in question is a dumb slave configured to connect via JNLP. It never was connected.

      There should be no warnings about responsiveness for nodes that aren't connected.

          [JENKINS-20272] Disconnected nodes don't need to be checked for reponse time

          Daniel Beck created issue -

          peter_schuetze added a comment - - edited

          I have lots of Nodes that are only used for deployments. They will only be taken online when needed and disconnect on 15 min inactivity. Looks very silly to have all of them marked as unresponsive just because they are offline. In addition, I am a fan of "only report what's an issue".

          peter_schuetze added a comment - - edited I have lots of Nodes that are only used for deployments. They will only be taken online when needed and disconnect on 15 min inactivity. Looks very silly to have all of them marked as unresponsive just because they are offline. In addition, I am a fan of "only report what's an issue".

          David Aldrich added a comment -

          If I mark a node as offline, I notice that Jenkins still tries to connect to it, fails and gives a warning. Is that the same point as stated above? I agree that Jenkins shouldn't try to connect to nodes marked offline, it fills the log with pointless warning messages.

          David Aldrich added a comment - If I mark a node as offline, I notice that Jenkins still tries to connect to it, fails and gives a warning. Is that the same point as stated above? I agree that Jenkins shouldn't try to connect to nodes marked offline, it fills the log with pointless warning messages.

          Daniel Beck added a comment -

          davida2009: Your slave retention strategy is "Keep online as much as possible", and that is what Jenkins does. "Temporarily mark offline" just makes it unavailable for building jobs. See also JENKINS-13140.

          Workaround: Build and install https://github.com/daniel-beck/jenkins-keep-slave-disconnected-plugin and configure the retention strategy provided by it.

          Daniel Beck added a comment - davida2009 : Your slave retention strategy is "Keep online as much as possible", and that is what Jenkins does. "Temporarily mark offline" just makes it unavailable for building jobs. See also JENKINS-13140 . Workaround: Build and install https://github.com/daniel-beck/jenkins-keep-slave-disconnected-plugin and configure the retention strategy provided by it.

          David Aldrich added a comment -

          Hi Daniel,
          Thanks for your reply, I understand now. I would like to try your plugin. Are there instructions for how to build it?

          Could you be persuaded to publish a pre-built version please?

          Best regards
          David

          David Aldrich added a comment - Hi Daniel, Thanks for your reply, I understand now. I would like to try your plugin. Are there instructions for how to build it? Could you be persuaded to publish a pre-built version please? Best regards David

          David Aldrich added a comment -

          Hi Daniel

          Thanks for making the 'Keep Offline Slaves Disconnected Retention Strategy Plugin' available through plugin manager. I have installed the plugin, restarted and set the Availability for nodes I have taken offline to:

          Keep this slave online as much as possible, but don't reconnect if temporarily marked offline by the user

          I no longer see messages in the log of type:

          Attempting to reconnect xxxx

          But I do still messages of type:

          Making xxxx offline because it’s not responding

          Is that what you would expect?

          Best regards

          David

          David Aldrich added a comment - Hi Daniel Thanks for making the 'Keep Offline Slaves Disconnected Retention Strategy Plugin' available through plugin manager. I have installed the plugin, restarted and set the Availability for nodes I have taken offline to: Keep this slave online as much as possible, but don't reconnect if temporarily marked offline by the user I no longer see messages in the log of type: Attempting to reconnect xxxx But I do still messages of type: Making xxxx offline because it’s not responding Is that what you would expect? Best regards David

          Daniel Beck added a comment -

          Hi David,

          that was all Nicolas – thank him.

          Making xxxx offline because it’s not responding

          That's a known issue in the response time monitor which doesn't care that a node is disconnected: JENKINS-20272

          Daniel Beck added a comment - Hi David, that was all Nicolas – thank him. Making xxxx offline because it’s not responding That's a known issue in the response time monitor which doesn't care that a node is disconnected: JENKINS-20272

          David Aldrich added a comment -

          Well, thank you Nicolas, if you are watching this issue.

          Thanks for your reply Daniel. I guess you don't mean JENKINS-20272 because that is this issue?

          David Aldrich added a comment - Well, thank you Nicolas, if you are watching this issue. Thanks for your reply Daniel. I guess you don't mean JENKINS-20272 because that is this issue?

          Daniel Beck added a comment -

          Uh, no, given your response I thought this was the reconnecting issue. This issue is still unresolved and it happens for all disconnected nodes, so yes, I'd expect this to happen.

          Daniel Beck added a comment - Uh, no, given your response I thought this was the reconnecting issue. This issue is still unresolved and it happens for all disconnected nodes, so yes, I'd expect this to happen.
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 151796 ] New: JNJira + In-Review [ 178067 ]

            olivergondza Oliver Gondža
            danielbeck Daniel Beck
            Votes:
            7 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved: