Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20559

hudson.Launcher:ProcStarter::envs() may throw NPE

    XMLWordPrintable

Details

    Description

      ProcStarter::envs() calls envs.clone(), but does not check envs variable for null. BTW, the variable may be null in the following case (see JENKINS-19506):

      • There are several wrappers
      • One of wrappers triggers remote call (Launcher::launch()) in setUp() or decorateLauncher() methods to setup variables (example: android-emulator) => it will make all other launchers to provide their environment variables
      • One of other wrappers retrieves ProcStarter.envs() in setUp() or decorateLauncher()
      • envs are empty for nested call => execution of other wrapper causes NPE inside core

      Attachments

        Issue Links

          Activity

            oleg_nenashev Oleg Nenashev created issue -
            oleg_nenashev Oleg Nenashev made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-19506 [ JENKINS-19506 ]
            oleg_nenashev Oleg Nenashev made changes -
            Link This issue is duplicated by JENKINS-19086 [ JENKINS-19086 ]
            oleg_nenashev Oleg Nenashev made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            danielbeck Daniel Beck made changes -
            Labels launcher launcher lts-candidate
            olivergondza Oliver Gondža made changes -
            Labels launcher lts-candidate 1.565.1-fixed launcher
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 152084 ] JNJira + In-Review [ 194203 ]

            People

              oleg_nenashev Oleg Nenashev
              oleg_nenashev Oleg Nenashev
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: