Jeff DeWan added a comment - 2013-11-25 23:50 I am experiencing the same behavior with a similar TypeError message in Firefox 25.0.1: TypeError: this._events is undefined ...resetConfig();},subscribe:function(b,c){this._events=this._events||{};if(!(b in ... element-min.js (line 7) The Jenkins server is v1.541. I can add other repository types (svn, git, cvs) just fine, only Mercurial seems to be a problem.

Jesse Glick added a comment - 2013-12-05 15:22 Also in 1.509.4.

Jesse Glick added a comment - 2013-12-05 18:10 Reproducible in standalone 1.509.4 with Mercurial and Multiple SCMs plugins installed, though not from hpi:run in the Mercurial plugin. Uncaught TypeError: Cannot read property 'click' of undefined @ element-min.js:7 a.addListener @ element-min.js:7 makeButton @ hudson-behavior.js:480 function makeButton(e,onclick) { var h = e.onclick; var clsName = e.className; var n = e.name; var btn = new YAHOO.widget.Button(e,{}); if (onclick!= null ) btn.addListener( "click" ,onclick); // HERE

Jesse Glick added a comment - 2013-12-05 18:21 The difference is the use of <c:select/> (at the recommendation of @stephenc) rather than plain <f:select/> . No clue why that would break something in JavaScript; the difference should only be on the server side.

Jesse Glick added a comment - 2013-12-05 18:28 https://github.com/jenkinsci/credentials-plugin/commit/23fc1cbbe4a73e33f062b3c588bab98b287ae8c9 is the difference.

Jesse Glick added a comment - 2013-12-05 18:30 Try downgrading Credentials to 1.9.2.

Jesse Glick added a comment - 2013-12-05 18:50 if (! this ._events[type]) { ( element-debug.js:694 ) with -Ddebug.YUI=true .

Jesse Glick added a comment - 2013-12-05 19:09 diff --git a/src/main/resources/lib/credentials/select.jelly b/src/main/resources/lib/credentials/select.jelly index 9ba0184..66a4c5e 100644 --- a/src/main/resources/lib/credentials/select.jelly +++ b/src/main/resources/lib/credentials/select.jelly @@ -47,25 +47,22 @@ <f:select style= "width:90%" clazz= "${attrs.clazz} credentials-select" field= "${attrs.field}" default= "${attrs.default}" /> <!-- TODO add support for checking permissions against stores in request path --> + <j:set var= "buttonId" value= "${h.generateId()}" /> + <st:nbsp/> <j:choose> <j:when test= "${h.hasPermission(app.getDescriptorByName( 'com.cloudbees.plugins.credentials.CredentialsSelectHelper' ).CREATE)}" > - <j:set var= "buttonId" value= "${h.generateId()}" /> - <st:nbsp/> <button id= "${buttonId}" type= "button" onclick= "return window.credentials.add();" > <img src= "${resURL}/plugin/credentials/images/16x16/new-credential.png" alt=""/> ${%Add} </button> - <script> makeButton($( '${buttonId}' ), window.credentials.add) </script> </j:when> <j:otherwise> <st:nbsp/> - <button id= "${buttonId}" type= "button" onclick= "return window.credentials.add();" disabled= "disabled" > + <button id= "${buttonId}" type= "button" disabled= "disabled" > <img src= "${resURL}/plugin/credentials/images/16x16/new-credential.png" alt=""/> ${%Add} </button> - <script> makeButton($( '${buttonId}' ), function () { - return false; - }) </script> </j:otherwise> </j:choose> + <script> makeButton($( '${buttonId}' )) </script> </j:jelly> \ No newline at end of file prevents this error when inside the Multiple SCMs section, but makes the button do nothing at all when used normally. Anyway, without this patch, when used normally (or with the patch, when used inside Multiple SCMs) the button does not work, for an apparently unrelated reason: GET http://localhost:8080/descriptor/com.cloudbees.plugins.credentials.CredentialsSelectHelper/dialog 404 (Not Found) @ prototype.js:1585 Ajax.Request.Class.create.request @ prototype.js:1585 Ajax.Request.Class.create.initialize @ prototype.js:1550 (anonymous function) @ prototype.js:452 klass @ prototype.js:101 window.credentials.add @ select.js:23

Jesse Glick added a comment - 2013-12-05 19:24 The 404 seems to be the result of an improper incremental build; fixed by clean build.

Jesse Glick added a comment - 2013-12-06 14:12 Seems to have been fixed in 1.9.4 by a different approach: https://github.com/jenkinsci/credentials-plugin/commit/07978d5c546329ff3301e28a11821897ee461d4a