Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21063

Indicate in icon (or tooltip) if a release build failed

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: m2release-plugin
    • Labels:
      None
    • Environment:
      n/a
    • Similar Issues:

      Description

      I find my self often stare at the release icons in the build history and not realize at first glance that some of them are failed release builds. This can of course be seen in the red ball of the build, but I'm thinking that it would be good if the release build icon would show this as well. At least the tooltip should clearly state that the release build failed.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          ahammar Anders Hammar created issue -
          ahammar Anders Hammar made changes -
          Field Original Value New Value
          Assignee teilo [ teilo ] Anders Hammar [ ahammar ]
          ahammar Anders Hammar made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Hide
          Permalink
          ahammar Anders Hammar added a comment -

          I'm fixing this by indicating in the badge if a release build failed (red 'x'). The tooltip will also state this by saying "Failed release...". To align the badge icons I'm replacing the old one for dryruns as well, with a yellow/orange '!' to indicate that it was a dryrun.

          Show
          ahammar Anders Hammar added a comment - I'm fixing this by indicating in the badge if a release build failed (red 'x'). The tooltip will also state this by saying "Failed release...". To align the badge icons I'm replacing the old one for dryruns as well, with a yellow/orange '!' to indicate that it was a dryrun.
          ahammar Anders Hammar made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Anders Hammar
          Path:
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly
          src/main/webapp/img/new-package.png
          src/main/webapp/img/releasebadge-dryrun.png
          src/main/webapp/img/releasebadge-failure.png
          src/main/webapp/img/releasebadge.png
          http://jenkins-ci.org/commit/m2release-plugin/8a166ef54883fdaf1e244cbd046d2e0908ee1adf
          Log:
          JENKINS-21063 Indicate in icon (or tooltip) if a release build failed.

          Failed release build is now indicated in badge/icon as well as tooltip. Also reworked dryrun badge to align.

          Signed-off-by: Anders Hammar <anders@hammar.net>

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly src/main/webapp/img/new-package.png src/main/webapp/img/releasebadge-dryrun.png src/main/webapp/img/releasebadge-failure.png src/main/webapp/img/releasebadge.png http://jenkins-ci.org/commit/m2release-plugin/8a166ef54883fdaf1e244cbd046d2e0908ee1adf Log: JENKINS-21063 Indicate in icon (or tooltip) if a release build failed. Failed release build is now indicated in badge/icon as well as tooltip. Also reworked dryrun badge to align. Signed-off-by: Anders Hammar <anders@hammar.net>
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Anders Hammar
          Path:
          pom.xml
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly
          src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeActionTest.java
          src/test/resources/org/jvnet/hudson/plugins/m2release/maven3-failing-project.zip
          http://jenkins-ci.org/commit/m2release-plugin/32529b14eec921c0f2baea34ca6bd6548246a9a3
          Log:
          JENKINS-21063 Badge now retrieves dryRun, version, and failedBuild info from build instead of storing it.

          As a side effect, variables in M2ReleaseBadgeAction were removed which will affect builds persisted with older versions of the plugin.
          Also, required version of Jenkins was bumped to 1.509.3.

          Signed-off-by: Anders Hammar <anders@hammar.net>

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: pom.xml src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeActionTest.java src/test/resources/org/jvnet/hudson/plugins/m2release/maven3-failing-project.zip http://jenkins-ci.org/commit/m2release-plugin/32529b14eec921c0f2baea34ca6bd6548246a9a3 Log: JENKINS-21063 Badge now retrieves dryRun, version, and failedBuild info from build instead of storing it. As a side effect, variables in M2ReleaseBadgeAction were removed which will affect builds persisted with older versions of the plugin. Also, required version of Jenkins was bumped to 1.509.3. Signed-off-by: Anders Hammar <anders@hammar.net>
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Anders Hammar
          Path:
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly
          src/main/webapp/img/releasebadge-failure.png
          src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeActionTest.java
          http://jenkins-ci.org/commit/m2release-plugin/1f8dc39b7b325c2be9b33a2640826ed0bb2a65e8
          Log:
          JENKINS-21063 Changed failed badge to indicate uncertainty wrt release and fixed backwards campatibility for builds by old versions of plugin.

          Signed-off-by: Anders Hammar <anders@hammar.net>

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly src/main/webapp/img/releasebadge-failure.png src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeActionTest.java http://jenkins-ci.org/commit/m2release-plugin/1f8dc39b7b325c2be9b33a2640826ed0bb2a65e8 Log: JENKINS-21063 Changed failed badge to indicate uncertainty wrt release and fixed backwards campatibility for builds by old versions of plugin. Signed-off-by: Anders Hammar <anders@hammar.net>
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Anders Hammar
          Path:
          pom.xml
          src/main/java/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper/config.jelly
          src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html
          src/main/webapp/help-projectConfig-selectAppendHudsonUsername.html
          http://jenkins-ci.org/commit/m2release-plugin/35d201a67b2e32850b68b75621aeb488cfe4c9df
          Log:
          Merge remote-tracking branch 'upstream/master' into JENKINS-21063

          • upstream/master:
            ReleasesCauses are now userIdCause - so update RSS appropriatly.
            [maven-release-plugin] prepare for next development iteration
            [maven-release-plugin] prepare release m2release-0.13.0
            Fixed a few UI text items in the project configuration dialog to align with text items in release dialog.
            [FIXED JENKINS-20983] Improve help text for "Preselect append Jenkins username" option
            [FIXED JENKINS-21060] Improve help text of "Number of successful release builds to keep"
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: pom.xml src/main/java/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper/config.jelly src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html src/main/webapp/help-projectConfig-selectAppendHudsonUsername.html http://jenkins-ci.org/commit/m2release-plugin/35d201a67b2e32850b68b75621aeb488cfe4c9df Log: Merge remote-tracking branch 'upstream/master' into JENKINS-21063 upstream/master: ReleasesCauses are now userIdCause - so update RSS appropriatly. [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release m2release-0.13.0 Fixed a few UI text items in the project configuration dialog to align with text items in release dialog. [FIXED JENKINS-20983] Improve help text for "Preselect append Jenkins username" option [FIXED JENKINS-21060] Improve help text of "Number of successful release builds to keep"
          Hide
          Permalink
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: imod
          Path:
          pom.xml
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly
          src/main/webapp/img/new-package.png
          src/main/webapp/img/releasebadge-dryrun.png
          src/main/webapp/img/releasebadge-failure.png
          src/main/webapp/img/releasebadge.png
          src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeActionTest.java
          src/test/resources/org/jvnet/hudson/plugins/m2release/maven3-failing-project.zip
          http://jenkins-ci.org/commit/m2release-plugin/aaba60e7307eea50ebc377403562364896f3d968
          Log:
          Merge branch 'JENKINS-21063' of https://github.com/andham/m2release-plugin into andham-JENKINS-21063

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: imod Path: pom.xml src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly src/main/webapp/img/new-package.png src/main/webapp/img/releasebadge-dryrun.png src/main/webapp/img/releasebadge-failure.png src/main/webapp/img/releasebadge.png src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeActionTest.java src/test/resources/org/jvnet/hudson/plugins/m2release/maven3-failing-project.zip http://jenkins-ci.org/commit/m2release-plugin/aaba60e7307eea50ebc377403562364896f3d968 Log: Merge branch ' JENKINS-21063 ' of https://github.com/andham/m2release-plugin into andham- JENKINS-21063
          ahammar Anders Hammar made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 152925 ] JNJira + In-Review [ 194395 ]

            People

            Assignee:
            ahammar Anders Hammar
            Reporter:
            ahammar Anders Hammar
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: