Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21223

Broken differences in build summary for failed builds

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • sloccount-plugin
    • None
    • All platforms, bug in code logic.

    Description

      Broken builds stores zero lines count which breaks the differences in build summary. See attached screenshots.

      Attachments

        1. build_09.png
          build_09.png
          21 kB
        2. build_10.png
          build_10.png
          19 kB
        3. build_11.png
          build_11.png
          18 kB
        4. build_12.png
          build_12.png
          21 kB

        Activity

          Ascending order - Click to sort in descending order
          mixalturek Michal Turek added a comment -

          Fixed in https://github.com/mixalturek/sloccount-plugin/commit/6371a727476c7b7a394e0fa4267bc82b9d74ec4a.

          mixalturek Michal Turek added a comment - Fixed in https://github.com/mixalturek/sloccount-plugin/commit/6371a727476c7b7a394e0fa4267bc82b9d74ec4a .
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/hudson/plugins/sloccount/ReportSummary.java
          src/main/java/hudson/plugins/sloccount/SloccountBuildAction.java
          src/main/java/hudson/plugins/sloccount/SloccountPublisher.java
          http://jenkins-ci.org/commit/sloccount-plugin/6371a727476c7b7a394e0fa4267bc82b9d74ec4a
          Log:
          JENKINS-21223 Broken differences in build summary for failed builds

          • Publishing the SLOCCount report will be skipped if the build fails, no data are stored for it and no data are displayed in build summary.
          • SloccountBuildAction.getPreviousAction() updated to search an action with valid data in a loop through previous builds. Builds that failed are skipped since they contain no data.
          • Unused imports removed.
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/hudson/plugins/sloccount/ReportSummary.java src/main/java/hudson/plugins/sloccount/SloccountBuildAction.java src/main/java/hudson/plugins/sloccount/SloccountPublisher.java http://jenkins-ci.org/commit/sloccount-plugin/6371a727476c7b7a394e0fa4267bc82b9d74ec4a Log: JENKINS-21223 Broken differences in build summary for failed builds Publishing the SLOCCount report will be skipped if the build fails, no data are stored for it and no data are displayed in build summary. SloccountBuildAction.getPreviousAction() updated to search an action with valid data in a loop through previous builds. Builds that failed are skipped since they contain no data. Unused imports removed.

          People

            mixalturek Michal Turek
            mixalturek Michal Turek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: