Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21532

Broken HTML in job configuration page

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • xunit-plugin
    • None
    • xunit-plugin 1.80

    Description

      <br><br> before Extra Configuration block is placed in bad place in HTML like this:

      ...
             <tr>
                <td class="setting-leftspace"> </td>
                <td class="setting-name">Choose your threshold mode</td>
                <td class="setting-main">
                 <input name="thresholdMode" value="1" type="radio" checked="true" />
                 <label class="attach-previous">Use a number of tests</label>
                 <br />
                 <input name="thresholdMode" value="2" type="radio" /><label class="attach-previous">Use a percent of tests</label>
                </td>
              </tr>
              <tr class="validation-error-area"><td colspan="2"></td><td></td></tr>
            </tbody></table>
          </td></tr>
        </td></tr>
        <br /><br />  <!-- This is wrong HTML!!!! -->
        <tr><td colspan="3">
          <tr>
            <td></td>
            <td></td>
      ...
      

      This happens used as both builder and publisher.

      Especially combined with Flexible Publish Plugin, this cause drop-down lists not to work (JENKINS-21497).

      Attachments

        Issue Links

          Activity

            ikedam ikedam created issue -
            ikedam ikedam made changes -
            Field Original Value New Value
            Link This issue is related to JENKINS-21497 [ JENKINS-21497 ]
            ikedam ikedam added a comment - pull request https://github.com/jenkinsci/xunit-plugin/pull/18

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly
            http://jenkins-ci.org/commit/xunit-plugin/bf7575017f1c85aa7ce3ee35f40a74d17d95d984
            Log:
            [FIXED JENKINS-21532] Fixed wrong placed <br>s.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly http://jenkins-ci.org/commit/xunit-plugin/bf7575017f1c85aa7ce3ee35f40a74d17d95d984 Log: [FIXED JENKINS-21532] Fixed wrong placed <br>s.
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]

            Code changed in jenkins
            User: Gregory Boissinot
            Path:
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly
            src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly
            http://jenkins-ci.org/commit/xunit-plugin/e0369f6aa2eaa36488e7dfb8a464bee4ac444eeb
            Log:
            Merge pull request #18 from ikedam/feature/JENKINS-21532

            JENKINS-21532 Fixed wrong placed <br>s.

            Compare: https://github.com/jenkinsci/xunit-plugin/compare/b763e52bceb8...e0369f6aa2ea

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/resources/org/jenkinsci/plugins/xunit/XUnitBuilder/config.jelly src/main/resources/org/jenkinsci/plugins/xunit/XUnitPublisher/config.jelly http://jenkins-ci.org/commit/xunit-plugin/e0369f6aa2eaa36488e7dfb8a464bee4ac444eeb Log: Merge pull request #18 from ikedam/feature/ JENKINS-21532 JENKINS-21532 Fixed wrong placed <br>s. Compare: https://github.com/jenkinsci/xunit-plugin/compare/b763e52bceb8...e0369f6aa2ea

            Awesome!

            Is it possible we can add some sort of HTML static checker for all .jelly to prevent this in the future?

            docwhat Christian Höltje added a comment - Awesome! Is it possible we can add some sort of HTML static checker for all .jelly to prevent this in the future?
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 153529 ] JNJira + In-Review [ 194573 ]

            People

              gbois Gregory Boissinot
              ikedam ikedam
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: