Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2202

Checkstyle and threshold

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • checkstyle-plugin
    • None
    • Platform: All, OS: All

    Description

      The Checkstyle result shows the warnings in 3 different priorities 'high',
      'normal' and 'low'. It would be nice to be able to differentiate between these
      warning levels in the project configuration "Unstable threshold" and "Health
      reporting".

      Attachments

        Activity

          drulli Ulli Hafner added a comment -

          How do you suggest to implement the health reporting part? Do you like to see
          health reporting for a given type of warnings only? (I think it makes no sense
          to mix entries for low, normal and high?) Or do you like to have an additional
          Listbox "consider only warnings with severity" "High", "High and Normal", "All".

          (BTW: for build failing threshold see also
          https://hudson.dev.java.net/issues/show_bug.cgi?id=2003.)

          drulli Ulli Hafner added a comment - How do you suggest to implement the health reporting part? Do you like to see health reporting for a given type of warnings only? (I think it makes no sense to mix entries for low, normal and high?) Or do you like to have an additional Listbox "consider only warnings with severity" "High", "High and Normal", "All". (BTW: for build failing threshold see also https://hudson.dev.java.net/issues/show_bug.cgi?id=2003 .)
          mast76 mast76 added a comment -

          Created an attachment (id=351)
          Configuration Mockup

          mast76 mast76 added a comment - Created an attachment (id=351) Configuration Mockup
          mast76 mast76 added a comment -

          I have added a mockup which shows what I had in mind.

          mast76 mast76 added a comment - I have added a mockup which shows what I had in mind.
          drulli Ulli Hafner added a comment -

          Wouldn't it make more sense to have only one line for health reporting, too?
          (And a checkbox consider only "high/hight&normal/all" for health reporting).

          Otherwise you are computing 4 numbers, these are then condensed into a single
          percentage (by average building).

          drulli Ulli Hafner added a comment - Wouldn't it make more sense to have only one line for health reporting, too? (And a checkbox consider only "high/hight&normal/all" for health reporting). Otherwise you are computing 4 numbers, these are then condensed into a single percentage (by average building).
          mast76 mast76 added a comment -

          My thoughts were based upon, that you might want to allow 100 normal priority
          but only 10 high priority ones within a given health status.

          mast76 mast76 added a comment - My thoughts were based upon, that you might want to allow 100 normal priority but only 10 high priority ones within a given health status.
          drulli Ulli Hafner added a comment -

          Ok, I see. That means if you have a percentage of 100% for high warnings and 50%
          for normal, then you get in total a percentage of 75%.

          drulli Ulli Hafner added a comment - Ok, I see. That means if you have a percentage of 100% for high warnings and 50% for normal, then you get in total a percentage of 75%.
          drulli Ulli Hafner added a comment -

          Another thing: how should the health graph react?

          Currently you have the total number of warnings shown in this graph (y axis).
          The colors are computed based of the healthiness thresholds. This will not work
          anymore. Any ideas?

          drulli Ulli Hafner added a comment - Another thing: how should the health graph react? Currently you have the total number of warnings shown in this graph (y axis). The colors are computed based of the healthiness thresholds. This will not work anymore. Any ideas?
          drulli Ulli Hafner added a comment -

          I fixed issue 2003 and introduced a radio button for warnings to include in stability and health evaluation. This is not exactly what you requested, but please have a look at it in the next release. Maybe we could refine this if required...

          Please reopen if you need some modifications.

          drulli Ulli Hafner added a comment - I fixed issue 2003 and introduced a radio button for warnings to include in stability and health evaluation. This is not exactly what you requested, but please have a look at it in the next release. Maybe we could refine this if required... Please reopen if you need some modifications.

          People

            drulli Ulli Hafner
            mast76 mast76
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: