Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22693

Resource leak in hudson.model.FileParameterValue

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      A FileInputStream is not closed in hudson.model.FileParameterValue for "return IOUtils.toByteArray(new FileInputStream(file))".
      This is a resource leak.

      The FileInputStream should be closed, using finally. For example:

      final InputStream input = new FileInputStream(file);
      try {
          return IOUtils.toByteArray(input);
      } finally {
          input.close();
      }
      

          [JENKINS-22693] Resource leak in hudson.model.FileParameterValue

          evernat created issue -
          evernat made changes -
          Description Original: A FileInputStream is not closed in [hudson.model.FileParameterValue|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/FileParameterValue.java#L260] for "return IOUtils.toByteArray(new FileInputStream(file))".
          This is a resource leak.

          The FileInputStream should be closed, using finally. For example:
          final InputStream input = new FileInputStream(file);
          try {
              return IOUtils.toByteArray(input);
          } finally {
              input.close();
          }
          New: A FileInputStream is not closed in [hudson.model.FileParameterValue|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/FileParameterValue.java#L260] for "return IOUtils.toByteArray(new FileInputStream(file))".
          This is a resource leak.

          The FileInputStream should be closed, using finally. For example:
          {code}
          final InputStream input = new FileInputStream(file);
          try {
              return IOUtils.toByteArray(input);
          } finally {
              input.close();
          }
          {code}
          Oleg Nenashev made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Oleg Nenashev added a comment -

          The PR just hangs for several weeks...
          https://github.com/jenkinsci/jenkins/pull/1225

          Oleg Nenashev added a comment - The PR just hangs for several weeks... https://github.com/jenkinsci/jenkins/pull/1225

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/FileParameterValue.java
          http://jenkins-ci.org/commit/jenkins/8767ddb192cf752c7d28f512884b9ecd3b9cdbd4
          Log:
          [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue

          Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/FileParameterValue.java http://jenkins-ci.org/commit/jenkins/8767ddb192cf752c7d28f512884b9ecd3b9cdbd4 Log: [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/src/main/java/hudson/model/FileParameterValue.java
          http://jenkins-ci.org/commit/jenkins/d2fb6d918c97b7b568eeff5b43e7095cbcb5d107
          Log:
          Merge pull request #1225 from synopsys-arc-oss/jenkins22693-inputstream-fix

          [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue

          Compare: https://github.com/jenkinsci/jenkins/compare/e7ca7ae9ec4a...d2fb6d918c97

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/FileParameterValue.java http://jenkins-ci.org/commit/jenkins/d2fb6d918c97b7b568eeff5b43e7095cbcb5d107 Log: Merge pull request #1225 from synopsys-arc-oss/jenkins22693-inputstream-fix [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue Compare: https://github.com/jenkinsci/jenkins/compare/e7ca7ae9ec4a...d2fb6d918c97

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3419
          [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue (Revision 8767ddb192cf752c7d28f512884b9ecd3b9cdbd4)

          Result = SUCCESS
          o.v.nenashev : 8767ddb192cf752c7d28f512884b9ecd3b9cdbd4
          Files :

          • core/src/main/java/hudson/model/FileParameterValue.java

          dogfood added a comment - Integrated in jenkins_main_trunk #3419 [FIXED JENKINS-22693] - Properly close InputStreams in FileParameterValue (Revision 8767ddb192cf752c7d28f512884b9ecd3b9cdbd4) Result = SUCCESS o.v.nenashev : 8767ddb192cf752c7d28f512884b9ecd3b9cdbd4 Files : core/src/main/java/hudson/model/FileParameterValue.java
          Daniel Beck made changes -
          Labels New: lts-candidate

            oleg_nenashev Oleg Nenashev
            evernat evernat
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: