Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22693

Resource leak in hudson.model.FileParameterValue

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      A FileInputStream is not closed in hudson.model.FileParameterValue for "return IOUtils.toByteArray(new FileInputStream(file))".
      This is a resource leak.

      The FileInputStream should be closed, using finally. For example:

      final InputStream input = new FileInputStream(file);
      try {
          return IOUtils.toByteArray(input);
      } finally {
          input.close();
      }
      

          [JENKINS-22693] Resource leak in hudson.model.FileParameterValue

          evernat created issue -
          evernat made changes -
          Description Original: A FileInputStream is not closed in [hudson.model.FileParameterValue|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/FileParameterValue.java#L260] for "return IOUtils.toByteArray(new FileInputStream(file))".
          This is a resource leak.

          The FileInputStream should be closed, using finally. For example:
          final InputStream input = new FileInputStream(file);
          try {
              return IOUtils.toByteArray(input);
          } finally {
              input.close();
          }
          New: A FileInputStream is not closed in [hudson.model.FileParameterValue|https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/FileParameterValue.java#L260] for "return IOUtils.toByteArray(new FileInputStream(file))".
          This is a resource leak.

          The FileInputStream should be closed, using finally. For example:
          {code}
          final InputStream input = new FileInputStream(file);
          try {
              return IOUtils.toByteArray(input);
          } finally {
              input.close();
          }
          {code}
          Oleg Nenashev made changes -
          Assignee New: Oleg Nenashev [ oleg_nenashev ]
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Daniel Beck made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.565.1-fixed
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 154804 ] New: JNJira + In-Review [ 195037 ]

            oleg_nenashev Oleg Nenashev
            evernat evernat
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: